Closed Bug 1150159 Opened 9 years ago Closed 9 years ago

Make retrigger check for scope login, rather than falling back to Persona thModelErrors

Categories

(Tree Management :: Treeherder, defect, P3)

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: jfrench, Assigned: jfrench)

References

()

Details

Attachments

(2 files)

So in bug 1136738 and PR387 we updated the Persona login message, but it doesn't appear to dismiss itself automatically like some other thNotify.send() messsages do.

Use case
o open treeherder while logged out
o select a job
o 'r' to retrigger
o you will get the expected "Please login.." message
o login via Persona

Expected
o the message asynchronously dismisses itself after ~5sec
eg. similar to when Save'ing a classification when logged out, which has a message display style without the [x] close ui

Observed
o the Persona message is persistent
Attached image persistentPersonaMsg
Observed per screen grab.
I think I have a simple fix for the retrigger for James, we just implement a scope thNotify for retrigger. It seems to work, but I just want to test it some more.
Assignee: nobody → tojonmz
Status: NEW → ASSIGNED
Summary: Make the Persona auth-error message transient like other login prompts. → Make retrigger check for scope login, rather than falling back to Persona thModelErrors
Attached file treeherder-ui-PR#449
Please see above PR for status and review.
Attachment #8587691 - Flags: review?(emorley)
Attachment #8587691 - Flags: review?(emorley) → review+
Thank you :-)
Marking fixed per above merge. I'll verify on the next push to stage/prod.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Verified fixed on stage.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: