Closed
Bug 1150159
Opened 9 years ago
Closed 9 years ago
Make retrigger check for scope login, rather than falling back to Persona thModelErrors
Categories
(Tree Management :: Treeherder, defect, P3)
Tree Management
Treeherder
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: jfrench, Assigned: jfrench)
References
()
Details
Attachments
(2 files)
So in bug 1136738 and PR387 we updated the Persona login message, but it doesn't appear to dismiss itself automatically like some other thNotify.send() messsages do. Use case o open treeherder while logged out o select a job o 'r' to retrigger o you will get the expected "Please login.." message o login via Persona Expected o the message asynchronously dismisses itself after ~5sec eg. similar to when Save'ing a classification when logged out, which has a message display style without the [x] close ui Observed o the Persona message is persistent
Assignee | ||
Comment 1•9 years ago
|
||
Observed per screen grab.
Assignee | ||
Comment 2•9 years ago
|
||
For reference, here's where we test for login eg. Saving https://github.com/mozilla/treeherder-ui/blob/8a3d8ae067cf256b9e9b8d359468606db1147330/webapp/app/plugins/pinboard.js#L79 And here's where we make it transient https://github.com/mozilla/treeherder-ui/blob/3ccfa7466999e8d19273caf705c54e5fea167f96/webapp/app/js/services/main.js#L178-L195
Assignee | ||
Comment 3•9 years ago
|
||
I think I have a simple fix for the retrigger for James, we just implement a scope thNotify for retrigger. It seems to work, but I just want to test it some more.
Assignee: nobody → tojonmz
Status: NEW → ASSIGNED
Summary: Make the Persona auth-error message transient like other login prompts. → Make retrigger check for scope login, rather than falling back to Persona thModelErrors
Assignee | ||
Comment 4•9 years ago
|
||
Please see above PR for status and review.
Attachment #8587691 -
Flags: review?(emorley)
Updated•9 years ago
|
Attachment #8587691 -
Flags: review?(emorley) → review+
Comment 5•9 years ago
|
||
Thank you :-)
Comment 6•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder-ui https://github.com/mozilla/treeherder-ui/commit/82e90b64dc28460873ac91acb721c32c9b3e2f51 Bug 1150159 - Make retrigger check for login w/non-sticky warning
Assignee | ||
Comment 7•9 years ago
|
||
Marking fixed per above merge. I'll verify on the next push to stage/prod.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment 9•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/4bc15a0a456c1244d7c7ed2a004ed70b8605b998 Bug 1150159 - Make retrigger check for login w/non-sticky warning
You need to log in
before you can comment on or make changes to this bug.
Description
•