Closed
Bug 1150638
Opened 9 years ago
Closed 9 years ago
[Customizer] Lazy-load the Customizer
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: justindarc, Assigned: justindarc)
References
Details
(Whiteboard: [spark])
Attachments
(1 file, 1 obsolete file)
In order to prevent the Customizer from using resources before it has been invoked, the bulk of the JS should be loaded lazily upon first invocation.
|
Assignee | |
Updated•9 years ago
|
Blocks: spark-customizer
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → jdarcangelo
|
|
Assignee | |
Comment 1•9 years ago
|
||
This is just part one. I moved all the controller/view initialization over to the MainController. Should make things easier to lazy-load now.
Attachment #8588078 -
Flags: review?(drs)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8588078 [details] [review] WIP pull-request (master) r- due only to the init marking pattern used. I left some other comments that are mostly just thinking out loud about where we are.
Attachment #8588078 -
Flags: review?(drs) → review-
|
|
Assignee | |
Comment 3•9 years ago
|
||
This is an updated version of the PR that actually lazy-evals the WCs. It also addresses your previous comments about dealing with the promise flag.
Attachment #8588078 -
Attachment is obsolete: true
Attachment #8590950 -
Flags: review?(drs)
|
|
||
Comment 4•9 years ago
|
||
Comment on attachment 8590950 [details] [review] pull-request (master) Looks good. I left some comments, but none of them are important to fix.
Attachment #8590950 -
Flags: review?(drs) → review+
|
|
Assignee | |
Comment 5•9 years ago
|
||
Addressed comments and landed on master: https://github.com/fxos/customizer/commit/be6c670b9375f4659485da099365d85de91c6283
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
||
Updated•9 years ago
|
Whiteboard: [spark]
You need to log in
before you can comment on or make changes to this bug.
Description
•