1150713 - Decommission /firefox/sms page

Status: RESOLVED FIXED

(www.mozilla.org :: Pages & Content, defect)

Description

[Cory Price [:ckprice] (bugmail disabled, NI me!)]

In bug 1139716 we are updating the /firefox/android product page to (among other things) include functionality that will allow a desktop user to send themselves a link (ref bug 1146982) from the product page instead of sending them to the /firefox/sms page.

This update will happen with 38.1 (June 2nd).

It would make sense to decommission the existing SMS page as it will now be redundant.

Comment 1

[Cory Price [:ckprice] (bugmail disabled, NI me!)]

Ben, any thoughts here? We can let the Growth Campaign deploy and do some observations there too. No real rush.

Comment 2

[Ben Niolet]

I don't have any strong opinions on the timing here. There may be some concerns from Mika on the language for that page, so given those questions it might make sense to decommission the page sooner, rather than later.

Comment 3

[Mika]

My suggestion is to either remove the checkbox and opt-in sentence now, or decommission the page.  Otherwise it's confusing what people are opting into since there is no current communication plan (and we'll have to maintain memory of the opt-in + any opt-outs).

Comment 4

[Malena Andrade [:malenita]]

Just to clarify am I removing this page?
https://www.mozilla.org/en-US/firefox/sms/

Seems we have implemented the sending yourself a link from desktop to mobile functionality on this page: https://www.mozilla.org/en-US/firefox/android

Comment 5

[Jennifer Bertsch [:jbertsch]]

Let's get this one wrapped up this month.

(In reply to Malena Andrade [:malenita] from comment #4)
> Just to clarify am I removing this page?
> https://www.mozilla.org/en-US/firefox/sms/
> 
> Seems we have implemented the sending yourself a link from desktop to mobile
> functionality on this page: https://www.mozilla.org/en-US/firefox/android

Yes  - let's remove /firefox/sms

Thx

Comment 6

[Steven Garrity [:sgarrity]]

We'll get this removed. I'll assume we should redirect /firefox/sms to /firefox/android as well.

Comment 7

[Jennifer Bertsch [:jbertsch]]

(In reply to Steven Garrity [:sgarrity] from comment #6)
> We'll get this removed. I'll assume we should redirect /firefox/sms to
> /firefox/android as well.

Actually, let's send it to /firefox/products.  Thx!

Comment 8

[Alex Gibson [:agibson]]

There are some old mcom-tests we can remove as part of this change:

https://github.com/mozilla/mcom-tests/blob/master/pages/desktop/sms.py
https://github.com/mozilla/mcom-tests/blob/master/tests/test_sms.py

These tests are in the process of being decommissioned/updated & moved to bedrock, but if we remove bedrock page before we get to these tests, we can just delete them. Thanks!

Comment 9

[Michael Gauthier [:gauthierm]]

PR to remove mcom-tests test cases https://github.com/mozilla/mcom-tests/pull/464

Comment 10

[Michael Gauthier [:gauthierm]]

PR to remove page from bedrock https://github.com/mozilla/bedrock/pull/3644

Comment 11

[Michael Gauthier [:gauthierm]]

PR is updated and squashed based on feedback.

Comment 12

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/abecde19109c84de73d45f6d65140c39ffa4bd53
Bug 1150713 Remove Firefox SMS page

 * Remove static resources and bundles for sms page.
 * Remove SMS page from firefox module.
 * Remove SMS form tests.
 * Redirect removed SMS page to firefox/products.
 * Add redirect tests for removed page.

https://github.com/mozilla/bedrock/commit/7d8dc40dd97e455850779f9ce4623399258751d6
Merge pull request #3644 from gauthierm/remove-firefox-sms-page

Bug 1150713 Remove Firefox SMS page

Comment 13

[Michael Gauthier [:gauthierm]]

New PR to remove somre more SMS references https://github.com/mozilla/bedrock/pull/3671

Comment 14

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/a703342d826b0b58ed9ef56ddef8bef37fe0871d
Bug 1150713 Remove straggler SMS page references

 * Update link and content on happy feedback page
 * Remove SMS form from FX37 welcome page

The happy feedback page is visible at /firefox/feedback?score=4.

The welcome page is visible at /firefox/37.0/whatsnew/. The old welcome page does geolocation to see if SMS is available. This can be triggered manually using /firefox/37.0/whatsnew/?geo=us. The updated page still does geolocation to populate the country flydown for the newsletter.

https://github.com/mozilla/bedrock/commit/b345c4d171b9381b82d70757809352925774eb2b
Merge pull request #3671 from gauthierm/remove-straggler-sms-references

Bug 1150713 Remove straggler SMS page references