Closed
Bug 1151402
Opened 9 years ago
Closed 9 years ago
make IAccessibleText and IAccessibleEditableText use proxies
Categories
(Core :: Disability Access APIs, defect)
Tracking
()
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: tbsaunde, Assigned: tbsaunde)
References
Details
Attachments
(1 file)
37.34 KB,
patch
|
davidb
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8588536 -
Flags: review?(dbolter)
Comment 2•9 years ago
|
||
Comment on attachment 8588536 [details] [diff] [review] proxy most of IAccessibleText and IAccessibleEditableText Review of attachment 8588536 [details] [diff] [review]: ----------------------------------------------------------------- LGTM. Just some formatting nits. I didn't grumble inline about how I wish we would always used braces even for single ifs. Onward! ::: accessible/ipc/DocAccessibleChild.h @@ +179,5 @@ > > virtual bool RecvDeleteText(const uint64_t& aID, > const int32_t& aStartPos, > + const int32_t& aEndPos, bool* aValid) > + MOZ_OVERRIDE; The MOZ_OVERRIDE usually goes at the end of the previous line. (same for RecvPasteText) ::: accessible/ipc/ProxyAccessible.cpp @@ +185,1 @@ > ProxyAccessible::TextSubstring(int32_t aStartOffset, int32_t aEndOfset, (We should fix the spelling of aEndOfset sometime but doesn't have to be here) ::: accessible/windows/ia2/ia2AccessibleEditableText.cpp @@ +93,5 @@ > A11Y_TRYBLOCK_BEGIN > > + if (ProxyAccessible* proxy = HyperTextProxyFor(this)) { > + return proxy->CutText(aStartOffset, aEndOffset) ? S_OK : E_INVALIDARG; > + } nit: block is indented 2 spaces too far. @@ +115,5 @@ > A11Y_TRYBLOCK_BEGIN > > + if (ProxyAccessible* proxy = HyperTextProxyFor(this)) { > + return proxy->PasteText(aOffset) ? S_OK : E_INVALIDARG; > + } nit: block is indented 2 spaces too far.
Attachment #8588536 -
Flags: review?(dbolter) → review+
Assignee | ||
Comment 3•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=e6a2e727bdc4
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e6a2e727bdc4
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Updated•9 years ago
|
Assignee: nobody → tbsaunde+mozbugs
You need to log in
before you can comment on or make changes to this bug.
Description
•