1151583 - Shell return code is set in odd places

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: patch

For some reason, certain errors in shell builtins cause us to set gExitCode. Even if the exception is caught and handled, gExitCode remains set and so we return a non-zero code on exit. I've been writing some command line JS code recently and this is really annoying. I looked through the blame and I can't find any reason it works this way.

Comment 1

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8588719 [details] [diff] [review]
patch

Review of attachment 8588719 [details] [diff] [review]:
-----------------------------------------------------------------

Wow, what a mess. Yet another error reporting mechanism. It seems like there ought to be a comment somewhere, but I'm not sure where.

AFAICT, the rule should be that if you're returning false without setting an exception, you can set gExitCode if you'd like a more specific exit code than EXITCODE_RUNTIME_ERROR. The two you removed may have been cargo-culted, or just random stabs at Doing The Right Thing.

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/830f6535aced

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/830f6535aced