Closed Bug 1151637 Opened 9 years ago Closed 9 years ago

Buttons at the bottom of buglists lack an ID

Categories

(Bugzilla :: User Interface, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 5.0

People

(Reporter: LpSolit, Assigned: LpSolit)

Details

Attachments

(2 files)

While investigating why Selenium scripts fail in 5.0, I realized that bug 276560 prevented Selenium from correctly identifying buttons, because they have no ID. They need one.
Attached patch patch, v1Splinter Review
Attachment #8588776 - Flags: review?(dkl)
Heh. I was just working around this issue in the test scripts by using XPATH instead. This is obviously better but wasn't sure we could get it in in time.

https://github.com/dklawren/qa/commit/53b894878b87fd2211c8b2e5a6078ca45bad7129

dkl
(In reply to David Lawrence [:dkl] from comment #2)
> Heh. I was just working around this issue in the test scripts by using XPATH
> instead.

Ah no, please don't use XPATH. This is a hack, and hard to maintain.
Comment on attachment 8588776 [details] [diff] [review]
patch, v1

Review of attachment 8588776 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl
Attachment #8588776 - Flags: review?(dkl) → review+
Flags: approval5.0+
Flags: approval+
To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
   ba69f97..9bd23db  master -> master

To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
   c2c8f77..fe7e0d0  5.0 -> 5.0
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
To ssh://gitolite3@git.mozilla.org/bugzilla/qa.git
   e028f4d..dc9312c  master -> master

To ssh://gitolite3@git.mozilla.org/bugzilla/qa.git
   2c08341..634547f  5.0 -> 5.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: