Closed
Bug 1151804
Opened 9 years ago
Closed 9 years ago
Candy Crush Saga doesn't load with dom.ipc.plugins.asyncInit set to true
Categories
(Core Graveyard :: Plug-ins, defect)
Core Graveyard
Plug-ins
Tracking
(firefox38 disabled, firefox39+ verified, firefox40+ verified)
RESOLVED
FIXED
mozilla40
People
(Reporter: guijoselito, Assigned: bugzilla)
References
Details
Attachments
(1 file, 1 obsolete file)
7.04 KB,
patch
|
jimm
:
review+
lizzard
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
I'm on Nightly with e10s off. Trying to play Candy Crush Saga (from Facebook), the app won't load, it gets stuck at 78% (when it probably do something different, like load something from elsewhere, I don't know).
Assignee | ||
Comment 1•9 years ago
|
||
I discovered that some plugin streams are being terminated prematurely when async init is on. The crux of the problem is that nsNPAPIPluginStreamListener::OnStartBinding is not always called when you would think it would be called by Necko; sometimes the underlying request has already completed. I've got a patch written that works for Candy Crush Saga but obviously I want to test it out a bit with other content.
Assignee: nobody → aklotz
Blocks: asyncplugininit
Status: NEW → ASSIGNED
status-firefox38:
--- → disabled
status-firefox39:
--- → affected
OS: Windows 7 → All
Hardware: x86_64 → All
Assignee | ||
Comment 2•9 years ago
|
||
Attachment #8591871 -
Flags: review?(jmathies)
Comment 3•9 years ago
|
||
Comment on attachment 8591871 [details] [diff] [review] Prevent premature stream termination Review of attachment 8591871 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/plugins/ipc/PluginAsyncSurrogate.cpp @@ +171,5 @@ > aFuncs->setvalue = &NPP_SetValue; > aFuncs->newstream = &NPP_NewStream; > aFuncs->setwindow = &NPP_SetWindow; > aFuncs->writeready = &NPP_WriteReady; > + aFuncs->write = &NPP_Write; This is set about 5 lines below to |&PluginModuleParent::NPP_Write| so this line doesn't appear to have any affect. Is that right?
Assignee | ||
Comment 4•9 years ago
|
||
Duh, that's silly of me. Fixed that. I also replaced the two bools that I added to the listener with an enum.
Attachment #8591871 -
Attachment is obsolete: true
Attachment #8591871 -
Flags: review?(jmathies)
Attachment #8592314 -
Flags: review?(jmathies)
Updated•9 years ago
|
Attachment #8592314 -
Flags: review?(jmathies) → review+
Assignee | ||
Comment 5•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/fdd746ef10bd
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/fdd746ef10bd
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Assignee | ||
Comment 7•9 years ago
|
||
Comment on attachment 8592314 [details] [diff] [review] Prevent premature stream termination (r2) Approval Request Comment [Feature/regressing bug #]: async plugin init [User impact if declined]: Plugins don't start properly, particularly Candy Crush Saga or other big games. This patch should also improve stability, so there would be unfixed stability problems. [Describe test coverage new/current, TreeHerder]: Tested with local and nightly builds with asyncInit enabled. [Risks and why]: Low. Simple patch that makes the browser more conservative with respect to terminating plugin streams. [String/UUID change made/needed]: None
Attachment #8592314 -
Flags: approval-mozilla-aurora?
Comment 8•9 years ago
|
||
Florin, can your team test this fix on nightly before we uplift it? Aaron, what other games might be useful to test?
Flags: needinfo?(florin.mezei)
Flags: needinfo?(aklotz)
Assignee | ||
Comment 10•9 years ago
|
||
(In reply to Liz Henry (:lizzard) from comment #8) > Aaron, what other games might be useful to test? Any game that is takes a while to start because it has a bunch of assets that need to be downloaded. FarmVille and other popular Facebook games are also good candidates.
Flags: needinfo?(aklotz)
Comment 11•9 years ago
|
||
Verified as fixed using the following environment: FF 40 Build Id: 20150416030209 OS: Win 7 x64
Updated•9 years ago
|
Flags: needinfo?(florin.mezei)
Comment 12•9 years ago
|
||
Comment on attachment 8592314 [details] [diff] [review] Prevent premature stream termination (r2) Approving for uplift to aurora.
Attachment #8592314 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 14•9 years ago
|
||
Backed out for test_pluginstream_err.html crashes. https://hg.mozilla.org/releases/mozilla-aurora/rev/a1d5331b1823 https://treeherder.mozilla.org/logviewer.html#?job_id=772938&repo=mozilla-aurora
Comment 16•9 years ago
|
||
u-a-f according to ASAN: https://treeherder.mozilla.org/logviewer.html#?job_id=773028&repo=mozilla-aurora
Assignee | ||
Comment 17•9 years ago
|
||
Relanded along with bug 1155503 uplift. https://hg.mozilla.org/releases/mozilla-aurora/rev/6b316eabf6e1
Comment 18•9 years ago
|
||
I verified this fix using: FF 39.0b2 Build Id: 20150601171003 OS: Win 7 x64, Mac Os X 10.9.5 and I've encountered an issue, candy crush saga is not completely loading when using a new profile, I've logged bug 1170486 for this issues.
Updated•9 years ago
|
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•