1151967 - Ensure TabQueueDispatcher has crash reporting enabled

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Martyn Haigh (:mhaigh)]

Ensure we call GeckoAppShell.ensureCrashHandling() in the TabQueueDispatcher onCreate method

Comment 1

[Martyn Haigh (:mhaigh)]

This needs to be enabled as it's now going to be a fairly big entry point in to the app, so if something goes wrong before BrowserApp is opened, we need to be able to capture that data

Comment 2

[Martyn Haigh (:mhaigh)]

Attachment: Ensure TabQueueDispatcher has crash reporting enabled

Comment 3

[Richard Newman [:rnewman]]

Comment on attachment 8590336 [details] [diff] [review]
Ensure TabQueueDispatcher has crash reporting  enabled

Review of attachment 8590336 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/tabqueue/TabQueueDispatcher.java
@@ +36,1 @@
>          Intent intent = getIntent();

Oh hey! Take a look at SafeIntent.

Comment 4

[Martyn Haigh (:mhaigh)]

https://hg.mozilla.org/integration/fx-team/rev/8595bcc0458a

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8595bcc0458a