Closed
Bug 1152486
Opened 9 years ago
Closed 9 years ago
[Calendar] split view selector logic into its own file
Categories
(Firefox OS Graveyard :: Gaia::Calendar, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mmedeiros, Assigned: mmedeiros)
References
Details
Attachments
(1 file)
right now the tabs (today, month, week, day) are handled inside the app.js, including the logic needed to update the current day. we should really create a new file inside "views/" to store this logic, "app.js" should contain the minimal logic required to bootstrap the app.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → mmedeiros
Comment 1•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Attachment #8590610 -
Flags: review?(gaye)
Comment 2•9 years ago
|
||
Comment on attachment 8590610 [details] [review] [gaia] millermedeiros:1152486-split-view-selector > mozilla-b2g:master LGTM!
Attachment #8590610 -
Flags: review?(gaye) → review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Updated•9 years ago
|
Keywords: checkin-needed
Comment 3•9 years ago
|
||
Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/629097847567e51095a454e7e63186a6e2ac0307
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•