1152531 - MMS data connection is never deactivated if MMS fails to send

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[pgravel]

MmsService never tries to deactivates the MMS data call in some error cases, which results in the MMS data call remaining up forever.

The case that I was able to reproduce consistently is due to an error with ensureRouting (separate bug), in which case the MMS data call remain up forever because MmsService doesn't seem to do proper cleanup in some cases.

Snippet of log from when the failure occurs:
> I Gecko   : -@- MmsService: Got the MMS network connected! Resend the buffered MMS requests: number: 1
> I Gecko   : -@- MmsService: flushPendingCallbacks: 1 pending callbacks with status: 0
> I Gecko   : -@- MmsService: Failed to ensureRouting: Error: Failed to resolve 'proxy.mobile.att.net', with status: 2152398878
> I Gecko   : -@- MmsService: The sending status of sendTransaction.run(): -8
> I Gecko   : -@- MmsService: The returned status of sending transaction: aErrorCode: 4 aEnvelopeId: null
> I Gecko   : -@- MmsService: Marking the delivery state/staus is done. Notify sent or failed.
> I Gecko   : -@- MmsService: Sending MMS failed.

Comment 1

[Ken Chang[:kenkai]]

Edgar, can you please check this bug?

Comment 2

[Edgar Chen [:edgar]]

(In reply to Ken Chang[:ken] from comment #1)
> Edgar, can you please check this bug?

Sure.

Comment 3

[Edgar Chen [:edgar]]

Hi pgravel, is it possible to share full log to us for investigating? Thank you.

Comment 4

[pgravel]

Hi Edgar

The log I attached to bug 1152568 would serve as a valid log for this bug. But I don't think they would help much. The relevant point of failure is included in the description.

Basic scenario is:
1. data is down
2. try to send mms
3. mmsService call SetupDataCallByType('mms')
4. data is brought up
5. mms service is notified data is available, tries resolve mms proxy
6. proxy fails to resolve for some reason (in this case it's due to the problem you mentioned in bug 1152568)
7. due to failure, MmsService never calls DeactivateDataCallByType('mms')

Comment 5

[Edgar Chen [:edgar]]

Attachment: mms_fail.log

This log is from bug 1152568.

Comment 6

[Edgar Chen [:edgar]]

Attachment: Patch, v1

Comment 7

[Edgar Chen [:edgar]]

Comment on attachment 8590668 [details] [diff] [review]
Patch, v1

Review of attachment 8590668 [details] [diff] [review]:
-----------------------------------------------------------------

Hi Bevis, may I have your review for this patch? Thank you.

Comment 8

[Bevis Tseng[:bevis][:btseng](Exited)]

Comment on attachment 8590668 [details] [diff] [review]
Patch, v1

Review of attachment 8590668 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.
Thanks for having this quick fix.

Comment 9

[Edgar Chen [:edgar]]

Try result: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f316d82ab6c1

Comment 10

[Edgar Chen [:edgar]]

Attachment: Patch,v2, r=bevis

Rebase only.

Comment 11

[Edgar Chen [:edgar]]

https://hg.mozilla.org/integration/b2g-inbound/rev/fac9c1f3729b

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/fac9c1f3729b

Comment 13

[Anshul]

Comment on attachment 8591456 [details] [diff] [review]
Patch,v2, r=bevis

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky): 
String or UUID changes made by this patch:

Comment 14

[Edgar Chen [:edgar]]

Comment on attachment 8591456 [details] [diff] [review]
Patch,v2, r=bevis

(In reply to Anshul from comment #13)
> Comment on attachment 8591456 [details] [diff] [review]
> Patch,v2, r=bevis
> 
> NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to
> better understand the B2G approval process and landings.
> 
> [Approval Request Comment]
> Bug caused by (feature/regressing bug #): 
> User impact if declined: 
> Testing completed: 
> Risk to taking this patch (and alternatives if risky): 
> String or UUID changes made by this patch:

v2.2 needs a rebased patch, I will attach it soon, and ask approval then.
Thank you, Anshul.

Comment 15

[Edgar Chen [:edgar]]

Attachment: [b2g37_v2_2] Patch, r=bevis

Patch for b2g37_v2_2.

Comment 16

[Edgar Chen [:edgar]]

Comment on attachment 8592070 [details] [diff] [review]
[b2g37_v2_2]  Patch, r=bevis

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 1032097.
User impact if declined: MMS connection is never deactivated if MMS fails to send due to ensureRouting error.
Testing completed: Manually test.
Risk to taking this patch (and alternatives if risky): Low
String or UUID changes made by this patch: None.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/0697e47968a2