1152604 - Multiple meta platform categories when showing only content in new profiler

Status: RESOLVED INVALID

(DevTools :: Performance Tools (Profiler/Timeline), defect, P3)

Description

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: Screen Shot 2015-04-08 at 4.54.26 PM.png

When recording a profile (via console.profile, although I don't think that matters), I saw two entries for "GC". After bug 1108843, these categories should always be combined if they are leaf nodes.

Comment 1

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: dupegc.json

Here's the profile that has duplicate GC entries.

Comment 2

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: extragc.json

It seems that the GC entry for "nsCycleCollector::forgetSkippable" is different than the GC entry for "js::Nursery::collect"

Comment 3

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

(In reply to Jordan Santell [:jsantell] [@jsantell] (Please needinfo) from comment #2)
> Created attachment 8710769 [details]
> extragc.json
> 
> It seems that the GC entry for "nsCycleCollector::forgetSkippable" is
> different than the GC entry for "js::Nursery::collect"

forgetSkippable should be CC not GC... is this not so?

Comment 4

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

I think this is because we create the tree from the samples before renaming to categories, so js::Nursery::collect and GCRuntime::collect would be different nodes in the tree, but they have the same category.

Comment 5

[Jordan Santell [:jsantell] [@jsantell]]

All the platform nodes should be flattened into the same category node -- GC is no different, we have many different Graphics, Network, etc frames with different function names, but combined to the same node (if on the same "depth" level)

Comment 6

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

(In reply to Jordan Santell [:jsantell] [@jsantell] (Please needinfo) from comment #5)
> All the platform nodes should be flattened into the same category node -- GC
> is no different, we have many different Graphics, Network, etc frames with
> different function names, but combined to the same node (if on the same
> "depth" level)

What if we have two sampled stacks:

1. JS->Pseudo(Gecko)->Psuedo(GC)
2. JS->Pseudo(GC)

Will these leaves be properly flattened to the same category node?

Comment 7

[Victor Porof [:vporof][:vp]]

Triaging. Filter on ADRENOCORTICOTROPIC (yes).

Comment 8

[Jan Honza Odvarko [:Honza] (always need-info? me)]

This report is related to the old DevTools profiler implementation, which has been removed. The Performance panel is now based on Firefox Profiler at https://profiler.firefox.com/
Closing as invalid