Closed
Bug 1152682
Opened 9 years ago
Closed 9 years ago
No such strategy errors in elements.js should be "invalid selector" errors
Categories
(Remote Protocol :: Marionette, defect)
Remote Protocol
Marionette
Tracking
(firefox40 fixed)
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: ato, Assigned: ato)
References
Details
(Keywords: pi-marionette-server)
Attachments
(1 file, 1 obsolete file)
The error types should change to "invalid selector" types to be in compliance with the WebDriver protocol. Affects elements.js:599 and elements.js:666.
Assignee | ||
Updated•9 years ago
|
Keywords: ateam-marionette-server
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → ato
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•9 years ago
|
||
/r/7295 - Bug 1152682: Correct invalid selector errors in elements.js Pull down this commit: hg pull -r 967032a652b3d244428d338c80b11610e8aa0e0c https://reviewboard-hg.mozilla.org/gecko/
Attachment #8594738 -
Flags: review?(dburns)
Assignee | ||
Comment 2•9 years ago
|
||
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=acdb5efb8315
Assignee | ||
Comment 3•9 years ago
|
||
Comment on attachment 8594738 [details] MozReview Request: bz://1152682/ato /r/7295 - Bug 1152682: Correct invalid selector errors in elements.js Pull down this commit: hg pull -r 967032a652b3d244428d338c80b11610e8aa0e0c https://reviewboard-hg.mozilla.org/gecko/
Attachment #8594738 -
Flags: review?(jgriffin)
Comment 4•9 years ago
|
||
https://reviewboard.mozilla.org/r/7295/#review6133 lgtm
Comment 5•9 years ago
|
||
https://reviewboard.mozilla.org/r/7295/#review6135 Ship It!
Updated•9 years ago
|
Attachment #8594738 -
Flags: review?(jgriffin) → review+
Assignee | ||
Updated•9 years ago
|
Attachment #8594738 -
Flags: review?(dburns)
https://hg.mozilla.org/mozilla-central/rev/9cfeed1582a3
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Assignee | ||
Comment 8•9 years ago
|
||
Attachment #8594738 -
Attachment is obsolete: true
Attachment #8619999 -
Flags: review+
Assignee | ||
Comment 9•9 years ago
|
||
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•