1152811 - Investigate perma-orange crash on browser_pluginCrashReportNonDeterminism.js and re-enable

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect, P2)

Description

[Mike Conley (:mconley) (:⚙️)]

Bug 1110887 introduced a new test to exercise our handling of some non-determinism with how the content and browser processes handle plugin process crashes.

That test seems to fail consistently on Linux when run in the suite. It seems that we hit a content process crash due to a MOZ_ABORT:

[Parent 22296] WARNING: '!aObserver', file /media/Projects/mozilla/mozilla-central/xpcom/ds/nsObserverService.cpp, line 287
[Child 22926] ###!!! ABORT: X_CreateGC: BadDrawable (invalid Pixmap or Window parameter); sync; id=0x4400008: file /media/Projects/mozilla/mozilla-central/toolkit/xre/nsX11ErrorHandler.cpp, line 157
#01: X11Error (/media/Projects/mozilla/mozilla-central/toolkit/xre/nsX11ErrorHandler.cpp:158)
[Child 22926] ###!!! ABORT: X_CreateGC: BadDrawable (invalid Pixmap or Window parameter); sync; id=0x4400008: file /media/Projects/mozilla/mozilla-central/toolkit/xre/nsX11ErrorHandler.cpp, line 157
Hit MOZ_CRASH() at /media/Projects/mozilla/mozilla-central/memory/mozalloc/mozalloc_abort.cpp:33

And here's a screenshot at the time of failure:

http://i.imgur.com/Tf7xbfb.png

I can reproduce this locally by running the test on a debug build with --run-until-failure. It only takes two or three repeats for the failure to rear its head.

We should figure out what's going on and re-enable the test.

Comment 1

[:Gijs (he/him)]

Let's start this off where the test lives, and if the issue is in another component we can always move it.

Comment 2

[Gabriele Svelto [:gsvelto] (PTO)]

I'm looking into this. I've run the tests locally together with other ones and it seems to be working again so maybe it's time to re-enable it.

Comment 3

[Gabriele Svelto [:gsvelto] (PTO)]

This doesn't seem to be happening anymore: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3342f1a9dea2b3de35638437fcdfb9493ea13ac2&selectedJob=144907816

Let's re-enable this.

Comment 4

[Gabriele Svelto [:gsvelto] (PTO)]

Attachment: Bug 1152811 - Re-enable browser_pluginCrashReportNonDeterminism.js;

Review commit: https://reviewboard.mozilla.org/r/200476/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/200476/

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8929181 [details]
Bug 1152811 - Re-enable browser_pluginCrashReportNonDeterminism.js;

https://reviewboard.mozilla.org/r/200476/#review205612

Thanks!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/30022d08636e
Re-enable browser_pluginCrashReportNonDeterminism.js; r=mconley

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/30022d08636e

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Might as well land this on Beta too, I reckon.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/0d20053d0805