Closed Bug 1152947 Opened 9 years ago Closed 9 years ago

Remove unnecessary expiresIn parameter when creating rooms

Categories

(Hello (Loop) :: Client, defect, P3)

defect
Points:
2

Tracking

(firefox40 fixed)

RESOLVED FIXED
mozilla40
Iteration:
40.1 - 13 Apr
Tracking Status
firefox40 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

When we first implemented rooms, "expiresIn" was a required parameter for room creation. That changed to optional at some stage, but we never updated the client.

I've double checked and the server timeout is the same as ours - 8 weeks. Its also better for it just to be set by the server, as then we don't have to change the clients should we ever want to adjust it.

It would help to have this cleaned up for some of the context work I'm doing.
Simple patch to remove the parameter. I've tested against the production server and checked the value of expiresAt returned in the response of the POST request.
Attachment #8590447 - Flags: review?(mdeboer)
Iteration: --- → 40.1 - 13 Apr
Points: --- → 2
Flags: qe-verify-
Flags: firefox-backlog+
Comment on attachment 8590447 [details] [diff] [review]
Remove expiresIn from the create room message for Hello as the server has its own default.

Review of attachment 8590447 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.
Attachment #8590447 - Flags: review?(mdeboer) → review+
https://hg.mozilla.org/mozilla-central/rev/6f32209af61a
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: