1153686 - HTMLMediaElement::UpdateReadyStateForData can lead to invalid audio format being reported.

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Jean-Yves Avenard [:jya]]

Under some circumstances, invalid audio track format can be reported.

HTMLMediaElement::UpdateReadyStateForData calls MetadataLoaded with a dummy MediaInfo object that is only properly constructed for the video track.

Problem was made worse by bug 1129263 as prior the invalid data was mostly ignored.

The MediaInfo object passed, contains the information from the default AudioInfo constructor. As such we will only ever report audio with 44.1kHz, Stereo with a track ID of 2.

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: Remove redundant mMediaSize member

Remove mMediaSize class member (and use mMediaInfo instead) and various reworks. The actual fix for this bug will come for free with bug 1153049. Various fixes/cleans along the way introduced in bug 1129263. Fix 'resize' event being fired twice

Comment 2

[Jean-Yves Avenard [:jya]]

Comment on attachment 8591494 [details] [diff] [review]
Remove redundant mMediaSize member

this cause resize event to be fired out of order. better fix coming

Comment 3

[Jean-Yves Avenard [:jya]]

Attachment: Remove redundant mMediaSize member

v2. https://treeherder.mozilla.org/#/jobs?repo=try&revision=c7e216283b7b

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8591564 [details] [diff] [review]
Remove redundant mMediaSize member

Review of attachment 8591564 [details] [diff] [review]:
-----------------------------------------------------------------

nice

Comment 5

[Jean-Yves Avenard [:jya]]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/818a69e48d38

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/818a69e48d38