1153704 - Highlight sync reflows

Status: RESOLVED INVALID

(DevTools :: Performance Tools (Profiler/Timeline), defect, P2)

Description

[Paul Rouget [:paul]]

We should highlight sync reflows in the waterfall, and point to the culprit JS function.

Comment 1

[Jordan Santell [:jsantell] [@jsantell]]

Any ideas of what this should look like? Chrome has a [warning] icon in the parent (at a lower opacity), and a warning icon next to the culprit marker. Currently we have a stack for any reflow marker that is sync, which should indiciate it's invalidation reason, but maybe we can also get more info on invalidations on platform.

Comment 2

[Paul Rouget [:paul]]

(In reply to Jordan Santell [:jsantell] [@jsantell] from comment #1)
> Any ideas of what this should look like? Chrome has a [warning] icon in the
> parent (at a lower opacity), and a warning icon next to the culprit marker.
> Currently we have a stack for any reflow marker that is sync, which should
> indiciate it's invalidation reason, but maybe we can also get more info on
> invalidations on platform.

The stack points to the JS function, which is already very good. Could we have the JS line too?

Comment 3

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: Screen Shot 2015-05-20 at 7.53.50 AM.png

We currently already have the function name and line number in the stack on any marker that has a stack.

Comment 4

[Victor Porof [:vporof][:vp]]

Triaging. Filter on ADRENOCORTICOTROPIC (yes).

Comment 5

[Jordan Santell [:jsantell] [@jsantell]]

Unassigning myself from bugs I won't be able to get to due to other commitments.

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me)]

This report is related to the old DevTools profiler implementation, which has been removed. The Performance panel is now based on Firefox Profiler at https://profiler.firefox.com/
Closing as invalid