Closed Bug 1153713 Opened 9 years ago Closed 9 years ago

[Stingray] images/ should not be pulled while installing smart-icons

Categories

(Firefox OS Graveyard :: Gaia::TV, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::TV
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: dwi2, Assigned: dwi2)

Details

Attachments

(1 file)

pull request
54 bytes, text/x-github-pull-request
johnhu
: review+
Details | Review 
Only font file and css file are allowed to install when installing with |bower install|.

All other files/directories should be listed in ‘ignore' section in bower.json
Assignee: nobody → tzhuang
Status: NEW → ASSIGNED
Attached file pull request — 
Hi John,

Please help to review the patch, thanks
Attachment #8591466 - Flags: review?(im)
Comment on attachment 8591466 [details] [review]
pull request

Looks good to me.
Attachment #8591466 - Flags: review?(im) → review+
Thanks.

This patch lands on smart-icons:master

https://github.com/smart-components/smart-icons/commit/2f16605d7c965c5d801149b9fed6598621342c54
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: