Closed Bug 1154041 Opened 9 years ago Closed 9 years ago

Enable child process memory reporting logging by default on B2G

Categories

(Toolkit :: about:memory, defect)

Product:
Toolkit
Component:
about:memory
Platform:
All
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla40
Tracking Flags:
Tracking Status
firefox40 --- fixed

People

(Reporter: jld, Assigned: jld)

Details

Attachments

(1 file)

bug1154041-memreplog-hg0.diff
1.17 KB, patch
erahm
: review+
Details | Diff | Splinter Review 
nsMemoryReporterManager.cpp has some compiled-out-by-default logging to stderr about the status of distributing memory report requests to child processes.  I think it should be enabled by default for B2G: multiprocess memory reporting is much more common/important there, and there's a general tendency towards more verbose logging on B2G.

Also, the logging should use printf_stderr(), which writes to the more useful Android logging service on B2G/Android (rather than only stderr, which is usually ignored there).

(This is already in my topic branch for bug 1151597 and friends, but it doesn't really belong in those bugs.)
Comment on attachment 8597469 [details] [diff] [review]
bug1154041-memreplog-hg0.diff

Review of attachment 8597469 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, this should be helpful for verifying memory reports are being properly triggered.
Attachment #8597469 - Flags: review?(erahm) → review+
https://hg.mozilla.org/mozilla-central/rev/bb344962d810
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: