Closed
Bug 1154150
Opened 9 years ago
Closed 9 years ago
don't create a FontFaceSet if we don't have any @font-face rules or FontFace objects
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla40
| Tracking | Status | |
|---|---|---|
| firefox40 | --- | fixed |
People
(Reporter: heycam, Assigned: heycam)
References
Details
Attachments
(1 file)
|
1.21 KB,
patch
|
jtd
:
review+
|
Details | Diff | Splinter Review |
We create a FontFaceSet object for every document, regardless of whether @font-face rules were used in its style sheets or document.fonts is touched. We should check whether the array of @font-face rules returned by the style set is non-empty before creating the FontFaceSet.
Attachment #8592066 -
Flags: review?(jdaggett)
|
Assignee | |
Comment 1•9 years ago
|
||
When a FontFace object is created from script, it calls aPresContext->Fonts() from its constructor, which causes the FontFaceSet to be created.
|
|
Assignee | |
Comment 2•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=54efcc453c6b (the red OS X builds are some transient problem)
|
||
Updated•9 years ago
|
Attachment #8592066 -
Flags: review?(jdaggett) → review+
|
||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/acfe0afcedee
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•