Closed Bug 1154158 Opened 9 years ago Closed 6 years ago

Can't comment deleted files

Categories

(MozReview Graveyard :: Review Board: Upstream, defect)

Product:
MozReview Graveyard
Component:
Review Board: Upstream
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED INVALID

People

(Reporter: glandium, Unassigned)

Details

(Whiteboard: [to be fixed in core]) 

Sometimes, something has to be said about a file being removed, and there's currently no way to do that.
:smacleod, is this going to be fixed with your upstream reviewboard work to improve diffs?
Flags: needinfo?(smacleod)
(In reply to Dan Minor [:dminor] from comment #1)
> :smacleod, is this going to be fixed with your upstream reviewboard work to
> improve diffs?

Sort of - I'm going to be adding the ability to toggle showing the contents of deleted files - so you could comment on the old deleted code. Actually just commenting on the entire deleted file won't be enabled by my work though.

That is definitely something core should get though. Until then a general comment in the top or bottom of the review will have to do.
Flags: needinfo?(smacleod)
Whiteboard: [to be fixed in core]
Product: Developer Services → MozReview
To build on comment 2, it sounds like this is *not* fixed in the upstream work referenced in bug 1114997; looks like that merely lets you see the content of a deleted file.
Component: General → Review Board: Upstream
(In reply to Mark Côté [:mcote] from comment #3)
> To build on comment 2, it sounds like this is *not* fixed in the upstream
> work referenced in bug 1114997; looks like that merely lets you see the
> content of a deleted file.

are you sure about that? if you can see the deleted file you *should* be able to comment on it...
Nope, not sure, which is why I said "sounds like". :)  The commit message says 'This change will make it possible to view deleted file content by providing a clickable link that is labelled "Show content."', and the "Testing Done" section says only that "deleted files could be correctly displayed on Chrome and Firefox without triggering a full page reload".  So it sounded like they kind of jury-rigged this in.  But I don't know for sure.
MozReview is now obsolete. Please use Phabricator instead. Closing this bug.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.