Closed
Bug 1155078
Opened 9 years ago
Closed 9 years ago
Only display domain name in the context part of the panel
Categories
(Hello (Loop) :: Client, defect, P2)
Hello (Loop)
Client
Tracking
(firefox40 fixed)
| Tracking | Status | |
|---|---|---|
| firefox40 | --- | fixed |
People
(Reporter: RT, Assigned: standard8)
References
Details
(Whiteboard: [context])
User Story
Currently when opening a panel the full URL of the active tab gets displayed in the panel within the context area. This is taking too much space on long URLs and this bug is a requirement to change it as follows: - Only display domain name without the "http://" header Example: Before: https://www.google.es/search?q=test&ie=utf-8&oe=utf-8&gws_rd=cr&ei=qHQvVaSqGMW5OKrjgZgI After: google.es
Attachments
(1 file)
|
5.33 KB,
patch
|
mikedeboer
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
||
Updated•9 years ago
|
Rank: 15
Flags: firefox-backlog+
Priority: -- → P2
Whiteboard: [context]
|
Assignee | |
Comment 1•9 years ago
|
||
This adjusts the display to only display the hostname.
Attachment #8597915 -
Flags: review?(mdeboer)
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → standard8
Iteration: --- → 40.3 - 11 May
Points: --- → 1
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8597915 [details] [diff] [review] Only display domain name in the context part of the panel. Review of attachment 8597915 [details] [diff] [review]: ----------------------------------------------------------------- LGTM! ::: browser/components/loop/content/js/panel.jsx @@ +702,5 @@ > render: function() { > + var hostname; > + > + try { > + hostname = (new URL(this.state.url)).hostname; nit: no need for the extra braces.
Attachment #8597915 -
Flags: review?(mdeboer) → review+
|
|
Assignee | |
Updated•9 years ago
|
Target Milestone: --- → mozilla40
|
||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4084f5eca1c6
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•