Closed
Bug 1155258
Opened 9 years ago
Closed 9 years ago
TempAllocPolicy::pod_realloc() throws away your data on OOM
Categories
(Core :: JavaScript: GC, defect)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla40
| Tracking | Status | |
|---|---|---|
| firefox40 | --- | fixed |
People
(Reporter: jonco, Assigned: jonco)
Details
Attachments
(1 file)
|
923 bytes,
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
Similar to bug 1154692. If OOM occurs we retry the allocation -- but we don't copy the caller's data. This is a fix, but I'm thinking we should rewrite onOutOfMemory() to have a clearer interface.
Attachment #8593448 -
Flags: review?(terrence)
|
||
Comment 1•9 years ago
|
||
Comment on attachment 8593448 [details] [diff] [review] temp-realloc-fix Review of attachment 8593448 [details] [diff] [review]: ----------------------------------------------------------------- I think there's already a bug open to rewrite all of this. Thanks for making the spot fixes in the meantime!
Attachment #8593448 -
Flags: review?(terrence) → review+
|
Assignee | |
Comment 2•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/07c36315c3f2
|
||
Comment 3•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/07c36315c3f2
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•