1155470 - WebGL2 - Implement Queries

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[u480271]

https://www.khronos.org/registry/webgl/specs/latest/2.0/#3.7.10

Comment 1

[u480271]

Attachment: Fix queries.

es3fTransformFeedbackTests exposed problems with queries. Queries are needed
to get the number of transformed primitives.

Comment 2

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8593724 [details] [diff] [review]
Fix queries.

Review of attachment 8593724 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/WebGL2ContextQueries.cpp
@@ +23,5 @@
>  static const char*
>  GetQueryTargetEnumString(GLenum target)
>  {
>      switch (target)
>      {

Can we switch this to `switch (foo) {` while we're at it?

@@ +67,5 @@
> +        return mActiveOcclusionQuery;
> +        
> +    case LOCAL_GL_TRANSFORM_FEEDBACK_PRIMITIVES_WRITTEN:
> +        return mActiveTransformFeedbackQuery;
> +        

Whitespace!

Comment 3

[u480271]

(In reply to Jeff Gilbert [:jgilbert] from comment #2)
> Can we switch this to `switch (foo) {` while we're at it?

of course.

> Whitespace!

Ooops. (Blames Visual Studio)

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f67a0b282680

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f67a0b282680