1155984 - Improve the performance of "self" in windows and workers

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

It's kinda slow right now, for no good reason.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Script for testcase

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Testcase

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Improve the performance of the "self" getter in both window and workers

Jason, could you review the Class.h change?

Peter, I could also make self on Window be Cached, not StoreInSlot, for a bit less complexity, but also a tiny bit slower code

Comment 4

[Peter Van der Beken [:peterv]]

Comment on attachment 8594344 [details] [diff] [review]
Improve the performance of the "self" getter in both window and workers

Review of attachment 8594344 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsGlobalWindow.cpp
@@ +2625,5 @@
> +      if (!JS_GetProperty(cx, newInnerGlobal, "self", &unused)) {
> +        NS_ERROR("can't create the 'self' property");
> +        return NS_ERROR_FAILURE;
> +      }
> +

No need for this blank line.

Comment 5

[Jason Orendorff [:jorendorff]]

Comment on attachment 8594344 [details] [diff] [review]
Improve the performance of the "self" getter in both window and workers

Review of attachment 8594344 [details] [diff] [review]:
-----------------------------------------------------------------

Sure.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c2c74fe15d1e

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c2c74fe15d1e