1156141 - Make switch from boot animation to first system app screen seamlessly

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Chiajung Hung [:chiajung]]

Currently, boot animation is stopped by GLinit or first swap buffer.
However, the powered by mozilla init logo is shown serveral frame later, we want to find the reason and make the switch smoother.

Comment 1

[Vincent Liu[:vliu]]

Attachment: console-mode-dump-DisplayList.log

From dumping the display list, it contains an div element with id:carrier-logo between bootanimation and the powered by mozilla init logo.

I/Gecko   ( 2874):   BackgroundColor p=0xab111410 f=0xb0fe57f0(HTMLScroll(div)(1) id:carrier-logo) bounds(0,0,19200,34160) layerBounds(0,0,19200,34160) visible(0,0,19200,34160) componentAlpha(0,0,0,0) clip(0,0,19200,34160)  uniform (opaque 0,0,19200,34160) (rgba 0,0,0,1) layer=0xa91d1800

A hack to change the attribute of background to make sure we hit the correct element. 

diff --git a/apps/system/style/system/initlogo.css b/apps/system/style/system/initlogo.css
index 56c49c7..a813eae 100644
--- a/apps/system/style/system/initlogo.css
+++ b/apps/system/style/system/initlogo.css
@@ -15,7 +15,7 @@
   overflow: hidden;
   width: 100%;
   height: 100%;
-  background: #000;
+  background: rgba(255, 0, 255, 1);
 }

Comment 2

[Vincent Liu[:vliu]]

Since this attribute set #000 in CSS, it means that even we don't put carrier-logo, gecko still paint this background(#000). This paint behavior causes switching from boot animation to the powered by mozilla init logo doesn't look seamlessly. The better way should remove this attribute in CSS. Once we need this attribute, we can operate it in js.

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] msliu:Bug-1156141-fix > mozilla-b2g:master

Comment 4

[Vincent Liu[:vliu]]

Attachment: Pull request for bug-1156141-fix

Hi Vivien,

Based on Comment 2, could you please have a review for the patch? Thanks.

Comment 5

[Vincent Liu[:vliu]]

Attachment: Pull request for bug-1156141-fix

Hi Alive,

As discussed, could you please help me to review it? Thanks.

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8598399 [details] [review]
Pull request for bug-1156141-fix

r=me

Comment 7

[GitHub Autolander Bot]

Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.

Comment 8

[GitHub Autolander Bot]

http://docs.taskcluster.net/tools/task-graph-inspector/#zBZc7dMjQrCAwYZgdu0nOA

The pull request failed to pass integration tests. It could not be landed, please try again.

Comment 9

[Vincent Liu[:vliu]]

(In reply to Autolander from comment #8)
> http://docs.taskcluster.net/tools/task-graph-inspector/
> #zBZc7dMjQrCAwYZgdu0nOA
> 
> The pull request failed to pass integration tests. It could not be landed,
> please try again.

Since I don't see any fail case for integration tests, I would set checkin-needed again.

Comment 10

[GitHub Autolander Bot]

http://docs.taskcluster.net/tools/task-graph-inspector/#RyGmlW-1S8m4JG44r-f0NA

The pull request failed to pass integration tests. It could not be landed, please try again.

Comment 11

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/bd4cb1a4d5889e54cd94599a6f545280428e51df

Comment 13

[Sotaro Ikeda [:sotaro]]

Nominate to "b2g-2.2+". bug 1171351 happens on b2g v2.2.

Comment 14

[Gregor Wagner [:gwagner]]

Vincent, please request for uplift approval.

Comment 15

[Vincent Liu[:vliu]]

Comment on attachment 8598399 [details] [review]
Pull request for bug-1156141-fix

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: The screen turns black in short period of time between boot animation and init-logo. 
Testing completed: 
Risk to taking this patch (and alternatives if risky): No risk to take this patch
String or UUID changes made by this patch:

Comment 16

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/3414b07dc489976bf510fd8042c0af3b1192c160