1157065 - GFX: MIPS: Optimize 2D operations by Loongson3 MMI

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[hev [:hev]]

Hi,

The GS464 core of Loongson3 implemented a SIMD ASE like as intel MMX, we call it Loongson3 MMI. This is a 64-bit SIMD instruction set, it isn't support floating point.

In public, it used by another open source project pixman for Loongson3. currently, we want to public some 2d operations implemented in LS3 MMI.

Comment 1

[hev [:hev]]

Attachment: 0001-GFX-2D-Add-Loongson3-MMI-helpers.patch

This is a helpers for translate SSE instruction interface to MMI and used by next patches.

Comment 2

[Timothy Nikkel (:tnikkel)]

Comment on attachment 8595687 [details] [diff] [review]
0001-GFX-2D-Add-Loongson3-MMI-helpers.patch

Did you mean to request review from me? I don't think I'm the right reviewer for this. Jeff or Bas can likely help here.

Comment 3

[hev [:hev]]

Attachment: 0002-GFX-2D-Implement-skia-Convolve-in-LS3-MMI.patch

This patch added a new source file convolverLS3.cpp, will build in every mips platforms, just enabled for Loongson3 (-march=loongson3a).

Comment 4

[hev [:hev]]

Attachment: 0003-GFX-2D-Implement-AlphaBoxBlur-in-LS3-MMI.patch

Comment 5

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8595706 [details] [diff] [review]
0002-GFX-2D-Implement-skia-Convolve-in-LS3-MMI.patch

Review of attachment 8595706 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/2d/moz.build
@@ +109,1 @@
>  

I don't think this is correct. There are mips chips without LS3.

Comment 6

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

(the actual code seems protected by #if defined(_MIPS_ARCH_LOONGSON3A) so it should be safe to build on all mips)

Comment 7

[hev [:hev]]

(In reply to Jeff Muizelaar [:jrmuizel] from comment #5)
> Comment on attachment 8595706 [details] [diff] [review]
> 0002-GFX-2D-Implement-skia-Convolve-in-LS3-MMI.patch
> 
> Review of attachment 8595706 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: gfx/2d/moz.build
> @@ +109,1 @@
> >  
> 
> I don't think this is correct. There are mips chips without LS3.

Thanks.

(In reply to Vladimir Vukicevic [:vlad] [:vladv] from comment #6)
> (the actual code seems protected by #if defined(_MIPS_ARCH_LOONGSON3A) so it
> should be safe to build on all mips)

You are right, Thanks for you help.

Comment 8

[hev [:hev]]

Comment on attachment 8595706 [details] [diff] [review]
0002-GFX-2D-Implement-skia-Convolve-in-LS3-MMI.patch

Review of attachment 8595706 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/2d/moz.build
@@ +109,1 @@
>  

Thanks, the real codes protected by '#if defined(_MIPS_ARCH_LOONGSON3A)'.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Can we please clean up the reviews here? I see pending ones and one patch that has an outright review- on it.

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3082e57356c7
https://hg.mozilla.org/integration/mozilla-inbound/rev/3518021ad9fa
https://hg.mozilla.org/integration/mozilla-inbound/rev/7e403c08e539

Comment 11

[hev [:hev]]

Attachment: 0004-GFX-Skia-Implement-SkUtils-in-LS3-MMI.patch

Comment 12

[hev [:hev]]

Attachment: 0005-GFX-Skia-Add-Loongson-MMI-helpers.patch

Comment 13

[hev [:hev]]

Attachment: 0006-GFX-Skia-Implement-SkBitmap-in-LS3-MMI.patch

Comment 14

[hev [:hev]]

Attachment: 0007-GFX-Skia-Implement-SkBlitRow-in-LS3-MMI.patch

Comment 15

[hev [:hev]]

Attachment: 0008-GFX-Skia-Implement-SkBlitMask-in-LS3-MMI.patch

Comment 16

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/3082e57356c7
https://hg.mozilla.org/mozilla-central/rev/3518021ad9fa
https://hg.mozilla.org/mozilla-central/rev/7e403c08e539

Comment 17

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8610294 [details] [diff] [review]
0004-GFX-Skia-Implement-SkUtils-in-LS3-MMI.patch

Review of attachment 8610294 [details] [diff] [review]:
-----------------------------------------------------------------

Please submit all of the skia optimizations to upstream skia. They will flow into our tree from there.