Closed
Bug 1157503
Opened 9 years ago
Closed 9 years ago
NewTabUtils.extractSite should try-catch nsIURI.asciiHost
Categories
(Firefox :: New Tab Page, defect)
Firefox
New Tab Page
Tracking
()
RESOLVED
FIXED
Firefox 40
People
(Reporter: adw, Assigned: adw)
References
Details
Attachments
(2 files, 1 obsolete file)
1.30 KB,
patch
|
ttaubert
:
review+
|
Details | Diff | Splinter Review |
1.36 KB,
patch
|
lizzard
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
dveditz was seeing an exception in NewTabUtils.extractSite: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIURI.asciiHost] from NewTabUtils::extractSite nsIURI.asciiHost throws NS_ERROR_FAILURE for nsJARURI and nsMozIconURI, and indeed he had some jar URIs in his PlacesProvider's top sites.
Attachment #8596244 -
Flags: feedback?(edilee)
Comment 1•9 years ago
|
||
Comment on attachment 8596244 [details] [diff] [review] patch No need for the extra uri and host variables anymore. We can just put the return newURI.asciiHost.replace directly in the try and catch return null because both try/catch blocks just return null. I suppose technically yes, .replace shouldn't throw and could be left outside of the try -- in this case, just a "let host" and one try block still.
Attachment #8596244 -
Flags: feedback?(edilee) → feedback+
Assignee | ||
Comment 2•9 years ago
|
||
Attachment #8596244 -
Attachment is obsolete: true
Attachment #8596654 -
Flags: review?(ttaubert)
Updated•9 years ago
|
Attachment #8596654 -
Flags: review?(ttaubert) → review+
Assignee | ||
Comment 3•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/6ac6d95398cc
Assignee: nobody → adw
Status: NEW → ASSIGNED
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6ac6d95398cc
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
Comment 5•9 years ago
|
||
Comment 6•9 years ago
|
||
Comment on attachment 8602804 [details] [diff] [review] for aurora Approved for uplift to aurora as requested in bug 1161412.
Attachment #8602804 -
Flags: approval-mozilla-aurora+
You need to log in
before you can comment on or make changes to this bug.
Description
•