Closed Bug 1157737 Opened 9 years ago Closed 9 years ago

[meta] Username and password is not autofilled on sites with dynamically generated login forms

Categories

(Firefox for iOS :: Browser, defect)

Product:
Firefox for iOS
Component:
Browser
Platform:
All
iOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
fxios 1.1+ ---

People

(Reporter: aaronmt, Assigned: fluffyemily)

References

(Depends on 2 open bugs,
URL
)

Details

(Keywords: meta)

Attachments

(1 file)

Pull request
48 bytes, text/x-github-pull-request
Details | Review 
https://instagram.com/accounts/login/

Login, save password, log-out, no autofill on the username/password field

Autofill is offered in Safari
tracking-fennec: ? → -
Not sure why this was minused. We have a remember password prompt that does nothing here.
tracking-fennec: ? → ---
tracking-fxios: --- → ?
tracking-fxios: ? → +
Component: General → Browser
Hardware: ARM → All
Aaron, can you drive generalizing this?
tracking-fxios: 1.1+ → +
OS: iOS 8 → iOS
Summary: Username and password is not autofilled on Instagram → Username and password is not autofilled on Instagram and other sites
Depends on: 1183257
Keywords: meta
Summary: Username and password is not autofilled on Instagram and other sites → [meta] Username and password is not autofilled on Instagram and other sites
Depends on: 1190992
Depends on: 1195764
We should see if WebKit gives us any help here.
tracking-fxios: + → 1.1+
Summary: [meta] Username and password is not autofilled on Instagram and other sites → [meta] Username and password is not autofilled on sites with dynamically generated login forms
Check to see if WebKit has some APIs/callbacks for seeing if password fields appear in the DOM.
Wasn't Emily working on this? Is there a WIP patch? Maybe we can improve things a little?
Flags: needinfo?(etoop)
there is not WIP patch - for some reason I can't find the branch I was working on. I added some notes to https://bugzilla.mozilla.org/show_bug.cgi?id=1190992
Flags: needinfo?(etoop)
Assignee: nobody → etoop
Status: NEW → ASSIGNED
Attached file Pull request — 

        Attachment #8664287 -
        Flags: review?(jhugman)

    
    

    
  
Comment on attachment 8664287 [details] [review]
Pull request

Comments in PR.

        Attachment #8664287 -
        Flags: review?(jhugman) → review+

    
    

    
  
Comment on attachment 8664287 [details] [review]
Pull request

I've updated this to reflect the convo around searching the mutations. Would like some feedback

        Attachment #8664287 -
        Flags: feedback?(jhugman)

        Attachment #8664287 -
        Flags: feedback?(bnicholson)

    
  

        Attachment #8664287 -
        Flags: feedback?(bnicholson)

    
    

    
  
Replied in PR. TL;DR the recursion/string matching isn't necessary at all; if a couple of assumptions are true then the code gets a lot simpler.

        Attachment #8664287 -
        Flags: review+

        Attachment #8664287 -
        Flags: feedback?(jhugman)

    
  
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED

    
  
Depends on: 1238098

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: