1157835 - Remove the MSVC_ENABLE_PGO flag

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[(Away)]

MSVC_ENABLE_PGO has had no effect after bug 1084162 landed six months ago.

Comment 1

[(Away)]

Attachment: moz.build files (automated, with hand-fixup)

Comment 2

[(Away)]

Attachment: python files (by hand)

Comment 3

[(Away)]

Attachment: python files (by hand)

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 8596889 [details] [diff] [review]
moz.build files (automated, with hand-fixup)

Review of attachment 8596889 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/skia/moz.build
@@ -880,5 @@
>              'trunk/src/opts/SkBlitRow_opts_SSE4_asm.S',
>          ]
>  
> -MSVC_ENABLE_PGO = True
> -

While you have it covered in the second patch, the generate_mozbuild.py change belongs in this patch.

Also note that gfx/angle/moz.build is generated by a generate_mozbuild.py that is *not* in the tree:
https://github.com/mozilla/angle/blob/mozilla/generate_mozbuild.py and that thus needs to be updated separately.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/76604a91617d

Comment 6

[(Away)]

(It occurred to me that the mozbuild test files probably all belonged in the same patch too, so I gave up trying to be clever folded them together)

Thanks :kamidphish for landing the ANGLE change: https://github.com/mozilla/angle/commit/bf3e0dda41a23b1319e7ae224640acbc52401f83

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/76604a91617d