Closed Bug 1157843 Opened 9 years ago Closed 9 years ago

TabManager memory leak

Categories

(Firefox for iOS :: General, defect)

Product:
Firefox for iOS
Component:
General
Platform:
Other
iOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
fennec + ---

People

(Reporter: wesj, Unassigned)

References

Details

Attachments

(1 file, 1 obsolete file)

PR https://github.com/mozilla/firefox-ios/pull/406
47 bytes, text/x-github-pull-request
st3fan
: review+
Details | Review 
      No description provided.

        Attachment #8596734 -
        Flags: review?(bnicholson)

    
    

    
  
Comment on attachment 8596734 [details] [review]
PR https://github.com/mozilla/firefox-ios/pull/370

Results in a startup crash...

        Attachment #8596734 -
        Flags: review?(bnicholson) → review-

    
    

    
  
Note that bug 1157394 just landed, so for whatever fix we end up with here, let's make sure all of our ViewMemoryLeakTests are passing to verify.
Blocks: 1130522
tracking-fennec: --- → ?
Summary: WeakTabManagerDelegate should use weak references → TabManager memory leak
tracking-fennec: ? → +

    
  
Blocks: ios-mem

    
    

    
  


  
Updated to not crash the world.

        Attachment #8596734 -
        Attachment is obsolete: true

    
    

    
  
Can you confirm all tests pass now with this fix?

    
    

    
  
All the tests that pass for me (not all of them), pass after this as well. The about:home ones give me grief with and without this patch. I gave up on fixing that.

    
  
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: