Closed Bug 1157946 Opened 9 years ago Closed 9 years ago

Fix more logspam in DAMP

Categories

(DevTools :: Debugger, defect)

Product:
DevTools
Component:
Debugger
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox40 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 40
Tracking Flags:
Tracking Status
firefox40 --- fixed

People

(Reporter: bgrins, Assigned: bgrins)

References

Details

Attachments

(1 file, 1 obsolete file)

damp-spam.patch
1.11 KB, patch
fitzgen
: review+
Details | Diff | Splinter Review 
This appears to happen when the toolbox is closed before _onSourcesAdded is fired in the debugger:

Handler function DebuggerClient.requester request callback threw an exception: TypeError: aResponse.sources is undefined
This can be "easily" reproduced in the damp test suite by following these instructions:

https://wiki.mozilla.org/Buildbot/Talos/Running#Running_locally_-_Source_Code
Then run: talos -n -d --develop --executablePath PATH_TO_FIREFOX --activeTests damp
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Depends on: 1153886
Blocks: 1158153
Attached patch damp-logspam.patch (obsolete) — — Splinter Review 

    
    

    
  
With this patch applied the crashes seem to change a bit: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8b49fb151328&exclusion_profile=false

    
    

    
  

      
      
      
      

        Attached patch
          
          
        damp-spam.patch
        — 
          — Splinter Review
      

    


  
Just a quick fix that cleans up the logspam

        Attachment #8597522 -
        Attachment is obsolete: true

        Attachment #8597531 -
        Flags: review?(nfitzgerald)

        Attachment #8597531 -
        Flags: review?(nfitzgerald) → review+

    
  
Keywords: checkin-needed

    
    

    
  
remote:   https://hg.mozilla.org/integration/fx-team/rev/18a5781a6b93
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/18a5781a6b93
Status: ASSIGNED → RESOLVED
Closed: 9 years ago

          status-firefox40:
          --- → fixed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 40

    
  
Product: Firefox → DevTools

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: