1158020 - Allow deleting bookmarks from the UI

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Wesley Johnston (:wesj)]

We should let you swipe to remove bookmarks in the bookmark list.

Comment 1

[Wesley Johnston (:wesj)]

Attachment: PR https://github.com/mozilla/firefox-ios/pull/374

This code is a bit... messy. Didn't show up until I tried to do more. I need to write some tests here, but I'm out for a few days. Figured I'd put this up.

Comment 2

[Richard Newman [:rnewman]]

Argh, this review request never made it into my inbox :/

My rnewman/db branch has deletion (by URL -- i.e., unstar), parenting, mobile bookmarks, folders, and such, and also has killed BookmarksSqlite, so this PR might be obsolete :(

Sorry!

Comment 3

[Richard Newman [:rnewman]]

I'm gonna grab what I can out of this on top of the bleeding edge.

Comment 4

[Richard Newman [:rnewman]]

Comment on attachment 8597033 [details] [review]
PR https://github.com/mozilla/firefox-ios/pull/374

UI stuff is rebased into https://github.com/mozilla/firefox-ios/pull/405, and will land with that.

Comment 5

[Wesley Johnston (:wesj)]

This landed, but I actually can't see anything on the bookmarks panel anymore.