1158219 - Python client sends field "id" with value null to switchToFrame when switching to default browser context

Status: RESOLVED FIXED

(Testing :: Marionette Client and Harness, defect)

Description

[Andreas Tolfsen ❲:ato❳]

The Python client sends a packet with the field "id" set to null when switching to the default browser context.  To make this switch, "id" should not be defined at all.

The reason this currently works is because we're using the == operator when comparing cmd.parameter.id.

Comment 1

[Andreas Tolfsen ❲:ato❳]

Discovered this when working on bug 1157258.

Comment 2

[Andreas Tolfsen ❲:ato❳]

Attachment: MozReview Request: bz://1158219/ato

/r/7623 - Bug 1158219: Don't set `id' field if undefined when switching frame

Pull down this commit:

hg pull -r cd490db0c8c18f68d4a91803daa833bc2f08631e https://reviewboard-hg.mozilla.org/gecko/

Comment 3

[Andreas Tolfsen ❲:ato❳]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2271072ed6fb

Comment 4

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8597351 [details]
MozReview Request: bz://1158219/ato

https://reviewboard.mozilla.org/r/7621/#review6389

lgtm!

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7602f3f4944f

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7602f3f4944f

Comment 8

[Andreas Tolfsen ❲:ato❳]

Attachment: MozReview Request: Bug 1158219: Don't set `id' field if undefined when switching frame

Comment 9

[Martijn Wargers (dead)]

I guess this comment and part of the check can be removed then too:
http://mxr.mozilla.org/mozilla-central/source/testing/marionette/driver.js#1645
1645     // Bug 1158219: Python client sends id when it shouldn't,
1646     // but we know that if it's null it wants us to switch to default
1647     if (cmd.parameters.id == null && !cmd.parameters.hasOwnProperty("element")) {

Comment 10

[Andreas Tolfsen ❲:ato❳]

(In reply to Martijn Wargers [:mwargers] (QA) from comment #9)
> I guess this comment and part of the check can be removed then too:
> http://mxr.mozilla.org/mozilla-central/source/testing/marionette/driver.
> js#1645
> 1645     // Bug 1158219: Python client sends id when it shouldn't,
> 1646     // but we know that if it's null it wants us to switch to default
> 1647     if (cmd.parameters.id == null &&
> !cmd.parameters.hasOwnProperty("element")) {

Filed bug 1202381 about this.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Moving bugs for Marionette client due to component changes.