1158665 - [Stingray][Home] After a card is added into a folder, align the folder list to the folder card

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV::Home, defect)

Description

[yifan [:yifan][:yliao]]

+++ This bug was initially created as a clone of Bug #1117699 +++

In edit mode, after a card is added into a folder, align the folder list to the folder card.

Comment 1

[yifan [:yifan][:yliao]]

Attachment: 1158665_patch.diff

This is the patch that fixes 

* Add a card into the last position in a folder when a folderScrollobale is reversed.
* Align the folderScrollable to the hovered folder in the cardScrollable when a card is added into an empty folder.

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] rexboy7:1158665-align-folder-list > mozilla-b2g:master

Comment 3

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8602679 [details] [review]
[gaia] rexboy7:1158665-align-folder-list > mozilla-b2g:master

The patch.

Tzu-lin may you help on reviewing this patch? If you are not available I can try changing reviewer.

Setting f? to yifan too.

Comment 4

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Comment on attachment 8602679 [details] [review]
[gaia] rexboy7:1158665-align-folder-list > mozilla-b2g:master

This looks good to me. Thanks

Comment 5

[yifan [:yifan][:yliao]]

Thanks for the patch!

Comment 6

[KM Lee [:rexboy] (inactivate after Sep. 22)]

After discussing with Yifan
We found the animation of moving card down to folderScrollable doesn't work as expect when:
(1)folder is rearranged and empty
(2)folder is at the edge of screen.
I'll open follow-up bug for it.

Comment 7

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Thanks for taking care of the patch Tzu-lin and Yifan.
master:
https://github.com/mozilla-b2g/gaia/commit/3692ad2cf3a047cc66f58f655a56b6ec559ef253