1158859 - Update newtab cog menu styling

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect)

Description

[Marina Samuel [:emtwo]]

Based on mocks here: https://bug1150228.bugzilla.mozilla.org/attachment.cgi?id=8592387

Comment 1

[Marina Samuel [:emtwo]]

Aaron, here's a build with the updated cog menu. Please let me know how this looks:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-4fb94d051c6b/try-macosx64/firefox-40.0a1.en-US.mac.dmg

Comment 2

[Marina Samuel [:emtwo]]

Attachment: part 1: v1: Update newtab cog menu styling

There's a link to a build to test out in comment 1 as well.

Comment 3

[Aaron]

Comments:

1.) Round the top corners of the menu dropdown container.

2.) On rollover, "Learn about new Tab" should be a blue bg with white text.

3.) Can we get rid of "What is this page?"? Pretty please!

Looks great - thank you.

Comment 4

[Ed Lee :Mardak]

(In reply to Aaron from comment #3)
> 3.) Can we get rid of "What is this page?"? Pretty please!
That's a separate bug 1145303

Comment 5

[Ed Lee :Mardak]

Comment on attachment 8601608 [details] [diff] [review]
part 1: v1: Update newtab cog menu styling

>+++ b/browser/base/content/newtab/newTab.xul
>+      <xul:label>New Tab Controls</xul:label>
>+        <xul:label>Show your top sites</xul:label>
We should have these as .dtd for Nightly 40 to support all locales (not just en-US). When we uplift to Aurora 39, we'll hardcode for en-US only and show the old menu for non-en-US.

Comment 6

[Marina Samuel [:emtwo]]

(In reply to Ed Lee :Mardak from comment #5)
> Comment on attachment 8601608 [details] [diff] [review]
> v1: Update newtab cog menu styling
> 
> >+++ b/browser/base/content/newtab/newTab.xul
> >+      <xul:label>New Tab Controls</xul:label>
> >+        <xul:label>Show your top sites</xul:label>
> We should have these as .dtd for Nightly 40 to support all locales (not just
> en-US). When we uplift to Aurora 39, we'll hardcode for en-US only and show
> the old menu for non-en-US.

This patch has hard-coded strings so it can be uplifted to Aurora. I assume we want to land this first then have a follow-up that puts the strings into a .dtd for nightly?

Comment 7

[Ed Lee :Mardak]

Sorry for the confusing timeline. We want to get strings into Nightly 40 before it becomes Aurora 40 so that 40 gets translated to all locales. We have a little bit more flexibility on uplifting hardcoded en-US strings because that doesn't break string freeze.

Comment 8

[Marina Samuel [:emtwo]]

Attachment: part 2 [strings] v1: Update newtab cog menu styling

This patch goes on top of the hard-coded strings patch to remove hard-coding and add localizable strings.

Comment 9

[Ed Lee :Mardak]

Attachment: for nightly combined

I combined emtwo's two patches into one that would be landing for nightly. We want to get this in before 40's string freeze when it moves to aurora.

Comment 10

[Ed Lee :Mardak]

Comment on attachment 8601608 [details] [diff] [review]
part 1: v1: Update newtab cog menu styling

clearing r? for now as this patch is for later uplift to 39

Comment 11

[Ed Lee :Mardak]

Comment on attachment 8602438 [details] [diff] [review]
part 2 [strings] v1: Update newtab cog menu styling

see attachment 8602881 [details] [diff] [review] for the combined patch

Comment 12

[Drew Willcoxon :adw]

Comment on attachment 8602881 [details] [diff] [review]
for nightly combined

Review of attachment 8602881 [details] [diff] [review]:
-----------------------------------------------------------------

Carrying over r+ on this combined patch.  I didn't actually look at it.

Comment 13

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/ff746c53035c

Comment 14

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/ff746c53035c

Comment 15

[Ed Lee :Mardak]

Attachment: for beta (Mardak will land)

Comment 16

[Ed Lee :Mardak]

Verified on os x nightly 2015-05-24

1) open new tab
2) point at top right customize menu and see the new border/styling
3) click customize icon and see the page fade out
4) checked hover behavior of "Show your top sites" and "Show blank page"
5) click options changes the new tab page for suggestions and blank
6) tested "learn about New Tab" (but page is still outdated)

Ran into Bug 1168628 where ctrl-tab switching away from the page causes the menu popup to disappear and leaves the page unusable until refresh.

Comment 17

[Ed Lee :Mardak]

Attachment: verify screenshot

Comment 18

[Cornel Ionce [:noni] [Hubs QA]]

Confirming the fix on Windows 7 64-bit, Mac OS X 10.9.5 and Ubuntu 14.04 32-bit using latest Aurora, build ID: 20150528004000.