Closed
Bug 1158874
Opened 9 years ago
Closed 9 years ago
Take some upstream perf fixes for hg blame
Categories
(Firefox Build System :: MozillaBuild, task)
Firefox Build System
MozillaBuild
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: RyanVM, Assigned: RyanVM)
References
Details
Attachments
(1 obsolete file)
Mozillabuild is going to ship with Mercurial 3.3.3. Some fixes for perf regressions with the blame command landed for 3.4 that we'd like to take as well.
Comment 1•9 years ago
|
||
http://selenic.com/repo/hg/rev/612ed41ae359 is 3.3.3 + 3 commits. This should be used as the base commit for MozillaBuild's Mercurial. http://selenic.com/repo/hg/rev/8d7d0bf62f9f should also be applied. http://www.selenic.com/pipermail/mercurial-devel/2015-April/069035.html is a patch against 3.4. It may need fuzz. We should wait for it to be formally accepted into 3.4 before taking the patch.
Assignee | ||
Comment 2•9 years ago
|
||
Roll-up patch of: http://selenic.com/repo/hg/rev/612ed41ae359 http://selenic.com/repo/hg/rev/8d7d0bf62f9f http://www.selenic.com/pipermail/mercurial-devel/2015-April/069035.html I had to rebase them a bit on top of the 3.3.3 release, so r? gps for a sanity check.
Comment 3•9 years ago
|
||
Comment on attachment 8598083 [details] [diff] [review] roll-up patch Review of attachment 8598083 [details] [diff] [review]: ----------------------------------------------------------------- LGTM.
Attachment #8598083 -
Flags: review?(gps) → review+
Comment 4•9 years ago
|
||
The patch posted to the mailing list has now been accepted to the stable branch. So, we shouldn't be concerned about accepting an unaccepted patch anymore.
Assignee | ||
Comment 5•9 years ago
|
||
Comment on attachment 8598083 [details] [diff] [review] roll-up patch Going to take 3.4.1 instead since it's out. Sorry for the lag - shooting for an RC build in the next day or so.
Attachment #8598083 -
Attachment is obsolete: true
Assignee | ||
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Updated•1 year ago
|
Product: mozilla.org → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•