Closed
Bug 1158876
Opened 9 years ago
Closed 9 years ago
Gonk socket I/O code always forwards data to main thread
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(firefox40 fixed)
RESOLVED
FIXED
2.2 S11 (1may)
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: tzimmermann, Assigned: tzimmermann)
References
Details
Attachments
(3 files, 1 obsolete file)
12.65 KB,
patch
|
qdot
:
review+
|
Details | Diff | Splinter Review |
14.40 KB,
patch
|
qdot
:
review+
|
Details | Diff | Splinter Review |
29.50 KB,
patch
|
tzimmermann
:
review+
|
Details | Diff | Splinter Review |
The socket I/O code in ipc/unixsocket always forwards received data to the main thread. This constraint must be removed if we want to optimize existing users or allow for new use cases, such as in BluetoothDaemonConnection.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8598076 -
Flags: review?(kyle)
Assignee | ||
Comment 2•9 years ago
|
||
Attachment #8598078 -
Flags: review?(kyle)
Assignee | ||
Comment 3•9 years ago
|
||
Attachment #8598079 -
Flags: review?(kyle)
Assignee | ||
Comment 4•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=94b687180bd1
Comment 5•9 years ago
|
||
Comment on attachment 8598076 [details] [diff] [review] [01] Bug 1158876: Rename |SocketConsumerBase| to |DataSocket| Review of attachment 8598076 [details] [diff] [review]: ----------------------------------------------------------------- ::: ipc/unixsocket/ListenSocket.cpp @@ +137,5 @@ > > +DataSocket* > +ListenSocketIO::GetDataSocket() > +{ > + return nullptr; // listen sockets cannot transfer data Nit: Is it worth asserting here?
Attachment #8598076 -
Flags: review?(kyle) → review+
Updated•9 years ago
|
Attachment #8598078 -
Flags: review?(kyle) → review+
Updated•9 years ago
|
Attachment #8598079 -
Flags: review?(kyle) → review+
Assignee | ||
Comment 6•9 years ago
|
||
Changes since v1: - crash when requesting |DataSocket| from |ListenSocketIO|
Attachment #8598076 -
Attachment is obsolete: true
Attachment #8598482 -
Flags: review+
https://hg.mozilla.org/integration/b2g-inbound/rev/8a3ef82cb417 https://hg.mozilla.org/integration/b2g-inbound/rev/730c7f25b895 https://hg.mozilla.org/integration/b2g-inbound/rev/7e28d47294b2
Assignee | ||
Comment 8•9 years ago
|
||
Thanks a lot. I added MOZ_CRASH to |ListenSocketIO::GetDataSocket|, but this will be cleaned up in another, larger patch set. https://treeherder.mozilla.org/#/jobs?repo=b2g-inbound&revision=7e28d47294b2
Comment 9•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8a3ef82cb417 https://hg.mozilla.org/mozilla-central/rev/730c7f25b895 https://hg.mozilla.org/mozilla-central/rev/7e28d47294b2
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S11 (1may)
You need to log in
before you can comment on or make changes to this bug.
Description
•