Closed Bug 1159056 Opened 9 years ago Closed 9 years ago

ScrollFrameHelper::SetCoordAttribute stores a value in css pixels in a variable with type nscoord

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla40
Tracking Flags:
Tracking Status
firefox40 --- fixed

People

(Reporter: tnikkel, Assigned: tnikkel)

Details

Attachments

(1 file)

patch
1.30 KB, patch
dholbert
: review+
Details | Diff | Splinter Review 
nscoord should be reserved for appunits.
Attached patch patch — — Splinter Review 

        Attachment #8598330 -
        Flags: review?(dholbert)

        Attachment #8598330 -
        Flags: review?(dholbert) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/2c738675bd82
Status: NEW → RESOLVED
Closed: 9 years ago

          status-firefox40:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40

    
    

    
  
Why pizelSize rather than pixelSize?

    
    

    
  
Oops. Surely that was a typo.
Flags: needinfo?(tnikkel)

    
    

    
  
Yes, it was a typo that went unnoticed. Thanks for noticing. I'll push a typo fix when I see inbound open. Leaving needinfo until that's done.

    
    

    
  
Pushed the typo fix.
Flags: needinfo?(tnikkel)

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: