1159699 - Calendar tab toolbar buttons are missing tooltips

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[aleth [:aleth]]

For a new user, it would be helpful if the calendar tab buttons (Synchronize, Event, Task,...) had explanatory tooltips which explain what the buttons are for (e.g. synchronize with what? does it open an Event view or add a new event or...?)

Comment 1

[Stefan Sitter [:ssitter]]

This is pretty easy, taking :)

Comment 2

[Stefan Sitter [:ssitter]]

Attachment: add tooltips to Calendar tab and Task tab toolbar buttons

Comment 3

[Matthew Mecca [:mmecca]]

Comment on attachment 8602914 [details] [diff] [review]
add tooltips to Calendar tab and Task tab toolbar buttons

Review of attachment 8602914 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, r=mmecca

::: calendar/locales/en-US/chrome/lightning/lightning-toolbar.dtd
@@ +7,5 @@
>  <!ENTITY lightning.toolbar.task.name "Task Toolbar">
>  <!ENTITY lightning.toolbar.task.name.accesskey "T">
>  
>  <!ENTITY lightning.toolbar.sync.label "Synchronize">
> +<!ENTITY lightning.toolbar.sync.tooltip "Reload calendar and synchronize changes">

We should probably use the plural form "calendars" here since all calendars are refreshed.

@@ +12,2 @@
>  <!ENTITY lightning.toolbar.delete.label "Delete">
> +<!ENTITY lightning.toolbar.delete.tooltip "Delete selected event or task">

Here also, since there could be multiple events or tasks deleted.

@@ +18,2 @@
>  <!ENTITY lightning.toolbar.print.label "Print">
> +<!ENTITY lightning.toolbar.print.tooltip "Print selected event or task">

Should this be more generic, since the print dialog isn't limited to the current selection? Maybe just "Print events and tasks"

Comment 4

[Stefan Sitter [:ssitter]]

(In reply to Matthew Mecca [:mmecca] from comment #3)
> We should probably use the plural form "calendars" here since all calendars
> are refreshed.
> ...
> Here also, since there could be multiple events or tasks deleted.

I tried to align with tooltips used in Thunderbird and they use singular although the command applies to one or more elements (e.g. Delete selected message or folder)

> Should this be more generic, since the print dialog isn't limited to the
> current selection? Maybe just "Print events and tasks"

Sure, I can update the patch.

Comment 5

[Stefan Sitter [:ssitter]]

Attachment: add tooltips to Calendar tab and Task tab toolbar buttons, v2

Comment 6

[Matthew Mecca [:mmecca]]

Comment on attachment 8613023 [details] [diff] [review]
add tooltips to Calendar tab and Task tab toolbar buttons, v2

r=mmecca

Comment 7

[Stefan Sitter [:ssitter]]

Pushed to https://hg.mozilla.org/comm-central/rev/331e683af864