11597 - eliminate NS_COMFALSE

Status: VERIFIED DUPLICATE of bug 8929

(Core :: XUL, defect, P3)

Description

[Warren Harris]

We should eliminate the NS_COMFALSE madness once and for all. Here's a list of
offending uses in your module -- please pass the bug along if there's someone
else who should deal with it.

      widget/src/xpwidgets/nsBaseWidget.cpp:
            View change log or Blame annotations
            line 566

Comment 1

[David Hyatt]

I don't know anything about this.  I've never written any code in this file.

Comment 2

[Warren Harris]

I looked up the author, looks like Mike Judge.

Comment 3

[mjudge]

yeah yeah we need to remove it since the javascript calls cant handle it. thats
fine but I dont think i will get to this anytime soon seeing how pervasive the
use of nsIEnumerators are now. the nsIBasicEnumerator is a "basic" version of a
javascript happy interface that should be usable. if anyone REALLY needs this
change then lets start a client wide acknowlegement to use nsIEnumerator2 for
example.

Comment 4

[Chris Petersen]

Based on mike's comments, marking as verified won't fix.

Comment 5

[brendan-obsolete]

If no one minds, I'll fix this after beta.  There is a client-wide move toward
nsISimpleEnumerator, it's been all over the xpcom newsgroup and in the mozilla
architecture meeting.  It isn't going to get constant fanfare, but it has
already happened to a great degree (query bugzilla for resolved bugs to do with
NS_COMFALSE).  The mailnews guys have done much great work.  Why stop short of
completion?

/be

Comment 6

[Warren Harris]

Good. We should get rid of all this crap like NS_COMFALSE and nsIEnumerator.
I'm glad someone's doing it.

Comment 7

[Brendan Eich [:brendan]]

I think braddr is driving this to a good conclusion throughout the tree.

/be

Comment 8

[Jim Roskind]

Since this cleanup task is not an M15 stability blocker, I'm pushing it off to 
M16 (to help allow us to branch for M15).

Comment 9

[John Dobbins]

NS_COMFALSE is no longer in /widget/src/xpwidgets/nsbasewidget.cpp

Search shows NO listing for NS_COMFALSE in /widget branch

This bug can be resolved fixed.

Comment 10

[Mike]

M16 has been out for a while now, these bugs target milestones need to be 
updated.

Comment 11

[Brad Roberts]

Moving out a few milestones.

Comment 12

[Oliver Klee]

Milestone 0.8 has been released. We should either resolve this bug or update its
milestone.

Comment 13

[karnaze (gone)]

Moving to XP Toolkit/Widgets component.

Comment 14

[Julien Cegarra]

I think this one was fixed long ago, so could we close it now ? 
and perhaps #11592, #11595 and some more in #8929...

/jc

Comment 15

[timeless]

i count 20 users that usually doesn't match my definition of eliminate (it 
might match decimate but ...)

Comment 16

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

*** This bug has been marked as a duplicate of 8929 ***

Comment 17

[Nick Bebout]

v