Closed
Bug 1159718
Opened 9 years ago
Closed 9 years ago
Remove notification when 'quick open' is activated in Tab Queue
Categories
(Firefox for Android Graveyard :: Overlays, defect)
Tracking
(firefox40 verified)
VERIFIED
FIXED
Firefox 40
Tracking | Status | |
---|---|---|
firefox40 | --- | verified |
People
(Reporter: mhaigh, Assigned: mhaigh)
References
Details
Attachments
(1 file)
3.38 KB,
patch
|
mcomella
:
review+
|
Details | Diff | Splinter Review |
As noted in https://bugzilla.mozilla.org/show_bug.cgi?id=1154425#c18 - with Tab Queue enabled, when you tap a link and wait for the toast to hide, then quickly (< 3 seconds) tap the same link again, the link is opened but the notification is not removed. We need to remove the notification if it's displayed when quick open is activated.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8599330 -
Flags: review?(michael.l.comella)
Comment on attachment 8599330 [details] [diff] [review] Remove notification when 'quick open' is activated in Tab Queue Review of attachment 8599330 [details] [diff] [review]: ----------------------------------------------------------------- ::: mobile/android/base/tabqueue/TabQueueHelper.java @@ +231,5 @@ > final SharedPreferences prefs = GeckoSharedPrefs.forApp(context); > prefs.edit().remove(PREF_TAB_QUEUE_COUNT).apply(); > } > > + static void removeNotification(Context context) { For my edification, any reason you preferred package-private to protected here? Unless I'm making a public API, I don't see much use in limiting subclass access.
Attachment #8599330 -
Flags: review?(michael.l.comella) → review+
Assignee | ||
Comment 3•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/3b908ec52d4e
Updated•9 years ago
|
Status: NEW → ASSIGNED
Component: General → Overlays
Assignee | ||
Comment 4•9 years ago
|
||
> For my edification, any reason you preferred package-private to protected
> here? Unless I'm making a public API, I don't see much use in limiting
> subclass access.
Old habit - no good reason in this case :)
https://hg.mozilla.org/mozilla-central/rev/3b908ec52d4e
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
Comment 6•9 years ago
|
||
Tapping a link external to Firefox will generate in the android notification bar "Nightly - 1 tab waiting" and tapping once again on the link will open it in Firefox in a new tab. The notification is removed from the notification bar. Verified as fixed using: Device: Samsung S5 (Android 4.4.2) Build: Firefox for Android 40.0a1 (2015-05-06)
Status: RESOLVED → VERIFIED
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•