1159720 - Don't automatically set prelim review queue for unlisted add-on on failed validation

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect)

Description

[Mathieu Agopian [:magopian]]

Attachment: Screen Shot 2015-04-29 at 15.31.21.png

We don't want to be in a position where developers not reading the text on the page would submit their add-on automatically to the unlisted prelim review queue if their add-on fails automatic validation.

What we want instead is a way to make sure the developer explicitly chooses to submit it to the prelim review queue by either showing a popup, or display an empty checkbox labeled "I want to submit this file through a manual review" that will need to be checked to enable the big blue "continue" button.

This same confirmation will be needed for new versions or files.

Comment 1

[Rob Hudson [:robhudson]]

PR: https://github.com/mozilla/olympia/pull/548

Comment 2

[Rob Hudson [:robhudson]]

https://github.com/mozilla/olympia/commit/ea10b8f61bde5a19114f62be21201fc0175cdba2

Comment 3

[Madalin Cotetiu]

Verified as fixed in FF38(Win7) in addons-dev.allizom.org
Postfix screncast: http://screencast.com/t/L4HsaRAnekh
Closing bug.