1160049 - [Messages] Attach menu should not dismiss when user cancel the replace attachment request

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Steve Chung [:steveck]]

After Bug #1156711 landed, the attachment menu will reuse the current shared option menu. Menu will be dismissed after clicking the option on the menu, but UX would prefer to keep it on top if user cancel the replace request. we might need to invent an option for enable menu closing manually in option menu.

Comment 1

[Julien Wajsberg [:julienw]]

[Blocking Requested - why for this release]:
Good catch; let's nominate it to keep this bug visible as it is a regression.

Comment 2

[Johan Lorenzo [:jlorenzo]]

Comms triage: Regression

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] steveck-chung:new-message-attachment-menu > mozilla-b2g:master

Comment 4

[Steve Chung [:steveck]]

Comment on attachment 8637823 [details] [review]
[gaia] steveck-chung:new-message-attachment-menu > mozilla-b2g:master

Hi Oleg, it's a small follow up for the attachment context menu regression. I think we only need it for replace case so I didn't move this part in generic error handling.

Comment 5

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8637823 [details] [review]
[gaia] steveck-chung:new-message-attachment-menu > mozilla-b2g:master

Hey Steve,

Sorry for the delay, I've left alternative proposition at GitHub that based on modified OptionMenu instead.

Please, tell me what you think!

Comment 6

[Steve Chung [:steveck]]

Comment on attachment 8637823 [details] [review]
[gaia] steveck-chung:new-message-attachment-menu > mozilla-b2g:master

Hi Oleg, I agree that the original solution is hacky because the option menu should be updated with part of  gaia-component in the future. So I didn't want to change the shared option menu at first. But adding this feature in option menu shouldn't cause regression anyway. I add the hideOnAction to item and see if you agree with this idea, thanks!

Comment 7

[Steve Chung [:steveck]]

Patch updated with name changed to "hideMenuManually", wdyt?

Comment 8

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8637823 [details] [review]
[gaia] steveck-chung:new-message-attachment-menu > mozilla-b2g:master

Sorry for a delay! Looks good to me now, just one question at GitHub,

Thanks!

Comment 9

[Morpheus Chen [:morpheus] UX]

After discussion with Steve, I have different view than the previous UX owner. I would prefer not to go back to show the option menu if user cancel the replace request, that is it will dismiss all option menu whenever user cancel the replace request. This can not only make it consistent with different apps across the OS, but also do give user the ability to actually "cancel". Besides, user can easily to replace the attachment by bringing out the option menu again. Does that make sense? Let me know if any questions, thanks.

Comment 10

[Steve Chung [:steveck]]

Close as worksforme per comment 9