Closed
Bug 1160661
Opened 9 years ago
Closed 9 years ago
[email] use gaia-theme.css to get transition-duration CSS variable
Categories
(Firefox OS Graveyard :: Gaia::E-Mail, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jrburke, Assigned: jrburke)
References
Details
Attachments
(1 file)
Bug 1143226 introduced a shorter animation direction, but uses a css variable from gaia-theme.css. Email should include that css file, so that it works.
Comment 1•9 years ago
|
||
Assignee | ||
Comment 2•9 years ago
|
||
Comment on attachment 8600483 [details] [review] [gaia] jrburke:bug1160661-email-gaia-theme-css > mozilla-b2g:master r+ from :asuth in IRC, where the fix was shared.
Attachment #8600483 -
Flags: review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Updated•9 years ago
|
Keywords: checkin-needed
Comment 3•9 years ago
|
||
Comment on attachment 8600483 [details] [review] [gaia] jrburke:bug1160661-email-gaia-theme-css > mozilla-b2g:master Applied locally, and it fixed the regression for me.
Attachment #8600483 -
Flags: feedback+
Assignee | ||
Updated•9 years ago
|
Depends on: fastandfurious
Comment 4•9 years ago
|
||
Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/2c1df1da6184d6f3ff875f24aeb3273f7d93d222
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment 5•9 years ago
|
||
This seems like something that should have been caught in the test suite, can we do anything to make sure this doesnt happen again?
Flags: needinfo?(jrburke)
Comment 6•9 years ago
|
||
Yes, this should have been caught by integration tests, which is my fault, one of my Q2 goals, and tracked on bug 975588. (There's been a history of cost/benefit triages.) But I do need to call out that the patch that caused this regression was changed after it was reviewed by jrburke, so it's also important to re-request review when making changes to a patch. Our revised integration test coverage will be good, but not so good that you can land unreviewed code.
Flags: needinfo?(jrburke)
You need to log in
before you can comment on or make changes to this bug.
Description
•