Closed
Bug 1160743
Opened 9 years ago
Closed 9 years ago
No nsIFile::RenameToNative
Categories
(Core :: XPCOM, enhancement)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla41
Tracking | Status | |
---|---|---|
firefox40 | --- | affected |
People
(Reporter: neil, Unassigned)
Details
Attachments
(1 file)
4.23 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
While looking into bug 1155963 I noticed the following code pattern: > NS_ConvertASCIItoUTF16 defDirName(NS_LITERAL_CSTRING(kDefaultDirectoryName)); > rv = persistentStorageDir->RenameTo(nullptr, defDirName); kDefaultDirectoryName is currently a const char array, so for bug 1155963 I changed the code to use a #define and NS_LITERAL_STRING. However I noticed the awkwardness was in part caused by the lack of a RenameToNative function. Nobody actually needs a RenameToNative at this point though.
Reporter | ||
Comment 1•9 years ago
|
||
Attachment #8600583 -
Flags: review?(nfroyd)
Updated•9 years ago
|
Attachment #8600583 -
Flags: review?(nfroyd) → review+
Reporter | ||
Comment 2•9 years ago
|
||
(In reply to comment #0) > kDefaultDirectoryName is currently a const char array, so for bug 1155963 I > changed the code to use a #define and NS_LITERAL_STRING. However I noticed > the awkwardness was in part caused by the lack of a RenameToNative function. Whoops, I seem to have accidentally landed this along with bug 1155963.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in
before you can comment on or make changes to this bug.
Description
•