Closed
Bug 1161104
Opened 9 years ago
Closed 9 years ago
Add a confirmation prompt when removing a theme
Categories
(Firefox OS Graveyard :: Gaia::Theme Editor, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: etienne, Assigned: hub, Mentored)
References
Details
(Whiteboard: [lang=js])
Attachments
(1 file)
|
Reporter | |
Updated•9 years ago
|
Blocks: spark-theme-editor
|
|
Reporter | |
Updated•9 years ago
|
Mentor: etienne
Whiteboard: [lang=js]
|
Assignee | |
Comment 2•9 years ago
|
||
Attachment #8603389 -
Flags: review?(etienne)
|
|
Assignee | |
Comment 3•9 years ago
|
||
Comment on attachment 8603389 [details] [review] Link to Github pull-request: https://github.com/fxos/studio/pull/7 Cancelling review for now. I need to address a few things first. Will update the PR and re-request.
Attachment #8603389 -
Flags: review?(etienne)
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8603389 -
Flags: review?(etienne)
|
|
Reporter | |
Comment 4•9 years ago
|
||
Comment on attachment 8603389 [details] [review] Link to Github pull-request: https://github.com/fxos/studio/pull/7 Thanks! r=me with nits
Attachment #8603389 -
Flags: review?(etienne) → review+
|
|
Assignee | |
Comment 5•9 years ago
|
||
addressed the nit. Rebase too for easy landing.
|
|
Assignee | |
Comment 6•9 years ago
|
||
Merged https://github.com/fxos/studio/commit/694ea0b820c689bca562946a27ca903112a8e8bf
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•