Closed
Bug 1161640
Opened 9 years ago
Closed 9 years ago
|mar_read_entire_file| can leak file descriptor (command line build utility)
Categories
(Toolkit :: Application Update, defect)
Toolkit
Application Update
Tracking
()
RESOLVED
FIXED
mozilla40
| Tracking | Status | |
|---|---|---|
| firefox40 | --- | fixed |
People
(Reporter: erahm, Assigned: joseriosneto, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: coverity, Whiteboard: [CID 1293422][lang=c++][good first bug])
Attachments
(1 file)
|
932 bytes,
patch
|
robert.strong.bugs
:
review+
|
Details | Diff | Splinter Review |
Coverity reports that |mar_read_entire_file| can leak file descriptor |f| if |fseeko| fails [1]. [1] https://hg.mozilla.org/mozilla-central/annotate/754579ec0e68/modules/libmar/verify/mar_verify.c#l38
|
||
Updated•9 years ago
|
Summary: |mar_read_entire_file| can leak file descriptor → |mar_read_entire_file| can leak file descriptor (command line build utility)
|
Reporter | |
Updated•9 years ago
|
Mentor: erahm
Whiteboard: [CID 1293422] → [CID 1293422][lang=c++][good first bug]
|
|
Reporter | |
Comment 2•9 years ago
|
||
Hi José, thank you for the interest! The bug is available for you to work on, please let me know if you need help getting started.
Flags: needinfo?(erahm)
Eric, here is a first patch of the solution.
Attachment #8602460 -
Flags: review?(erahm)
|
|
||
Comment 4•9 years ago
|
||
Comment on attachment 8602460 [details] [diff] [review] bug1161640_moving_fclose.patch Thanks and much appreciated! If you'd like to help out some more there is also bug 1161666 and bug 1161686. I'll land this tonight
Attachment #8602460 -
Flags: review?(erahm) → review+
|
|
||
Updated•9 years ago
|
Assignee: nobody → joseriosneto
|
|
||
Updated•9 years ago
|
Flags: in-testsuite-
Target Milestone: --- → mozilla40
|
|
||
Updated•9 years ago
|
Mentor: robert.strong.bugs
|
||
Updated•6 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•