1162134 - IonMonkey MIPS: Fix build failure on MIPS (js/src/jit/CodeGenerator.cpp:6740:28: error: ‘obj’ was not declared in this scope)

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Aleksandar Zlicic]

Build error:
js/src/jit/CodeGenerator.cpp:6740:28: error: ‘obj’ was not declared in this scope

Comment 1

[Aleksandar Zlicic]

Attachment: Bug_1162134.patch

Patch fixes the build on MIPS.

Build failure was caused by a typo (presumably) in attachment 8590332 [details] [diff] [review].
(Bug 1146597)

Comment 2

[Brian Hackett [Laid off!]]

Comment on attachment 8602207 [details] [diff] [review]
Bug_1162134.patch

Review of attachment 8602207 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/CodeGenerator.cpp
@@ +6736,5 @@
>      if (unboxedType == JSVAL_TYPE_MAGIC) {
>          Address initLength(elements, ObjectElements::offsetOfInitializedLength());
>          masm.branchKey(Assembler::NotEqual, initLength, ToInt32Key(index), &callStub);
>      } else {
> +        Address initLength(elements, UnboxedArrayObject::offsetOfCapacityIndexAndInitializedLength());

This should be |object|, not |elements|

Comment 3

[Aleksandar Zlicic]

Attachment: Bug_1162134.patch

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/681762b5ea5d

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/681762b5ea5d