1162142 - [User Story] Search Suggestions in the AwesomeBar should be clearly identified as such

Status: RESOLVED FIXED

(Firefox :: Search, defect, P1)

Description

[Kev Needham [:kev]]

Ensure search suggestions presented in the AwesomeBar drop-down list can be clearly identified as a suggest, for the purpose of helping users understand that selecting a suggestion will result in a search being performed.

Comment 1

[:shell escalante]

this bug relates to user story 3 here https://docs.google.com/document/d/1de2o8Osl_z98BBfkt243i-dHdcKmQB15xJ9rShkwk3Q/edit... which was the last part of initial talk for v1 minimum.

Comment 2

[:shell escalante]

initial work is done, but we should have enough to start and take what crops up as it does.  STeve - attach info

Comment 3

[Stephen Horlander [:shorlander]]

Attachment: AwesomeBar Search Indicator — 01

When performing a search from the AwesomeBar the Search Indicator Icon (Magnifying Glass) appears next to the search suggest entry and in the AwesomeBar field.

A search action label "— Search <Provider Name>" appears next to the entry when it is highlighted or hovered.

Comment 4

[:shell escalante]

Hi Drew - for priority this is after the "opt-in/opt-out" - but looks like the UX is ready to go if Bug 959565 is blocked for UX.  I just need info'd Steve to ask about the UX for that other bug.

Comment 5

[Drew Willcoxon :adw]

(In reply to Stephen Horlander [:shorlander] from comment #3)
> When performing a search from the AwesomeBar the Search Indicator Icon
> (Magnifying Glass) appears next to the search suggest entry

We do this already...

> and in the AwesomeBar field.

... but not this.

> A search action label "— Search <Provider Name>" appears next to the entry
> when it is highlighted or hovered.

We do this already too.

So the only thing to do in this bug is to show the magnifying glass in the awesomebar.

Comment 6

[Drew Willcoxon :adw]

Attachment: patch

This seems to work...  The selectors and values are based on those for the identity-box in each theme's CSS.

Comment 7

[Marco Bonardo [:mak]]

so, why don't we just put the icon in identity-box and switch it with page-proxy-favicon, instead of copying over all the code? regardless, afaict, when using autocomplete we always use the generic icon there, the risk should be low.

Comment 8

[Drew Willcoxon :adw]

Attachment: patch v2

This actually uses page-proxy-favicon itself and switches its image.

Comment 9

[Marco Bonardo [:mak]]

Comment on attachment 8626404 [details] [diff] [review]
patch v2

Review of attachment 8626404 [details] [diff] [review]:
-----------------------------------------------------------------

This is definitely simpler and less likely to break.

::: browser/themes/osx/browser.css
@@ +1809,5 @@
>    }
>  }
>  
> +#urlbar[actiontype="searchengine"] > #identity-box > #page-proxy-favicon {
> +  -moz-image-region: inherit;

it looks to me the osx theme is only overriding -moz-image-region from identity-block.inc.css, do we really need to set everything rather than just that?

Comment 10

[Drew Willcoxon :adw]

https://hg.mozilla.org/integration/fx-team/rev/bfa8b42bd280

You're right, I removed the OS X-specific CSS and it still worked, so the final patch only modifies identity-block.inc.css, nice.

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bfa8b42bd280