1162199 - Use unboxed objects by default

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Brian Hackett [Laid off!]]

Attachment: patch

Unboxed objects improve all our major benchmarks (octane by 2-3%) and don't regress any of the assorted tests on AWFY.  They're also a good memory savings when we can use them.  The attached patch turns them on by default.  I'll wait to land this until after the next merge and after bug 1161762 is fixed (the only remaining unboxed object crash I think.)

Since there isn't any need to control these with an about:config option I removed the unboxed objects option from RuntimeOptions and added a flag in JitOptions, as Hannes suggested in bug 1153266.  I hope that eventually this file will be generalized so that it isn't JIT specific, but for now this doesn't seem too bad and the weirdness with the different control mechanism for unboxed arrays will be fixed when they are also on by default.

Comment 1

[Benjamin Bouvier [:bbouvier] (inactive)]

Fuzzing team: when this patch lands, --unboxed-objects won't be available anymore, and will be replaced by the opposite --no-unboxed-objects, still useful to test (in differential mode at least).

Comment 2

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Got it. Thanks for the headsup!

Comment 3

[Benjamin Bouvier [:bbouvier] (inactive)]

For the record, decoder asked on irc to mark open and potentially dangerous unboxed-objects bugs as s-s, but this list [0] doesn't show bugs without patches (note the unassigned one is actually about debugging, not about unboxed objects, although it triggers with --unboxed-objects).

[0] https://bugzilla.mozilla.org/buglist.cgi?emailreporter1=1&list_id=12235502&resolution=---&emailtype1=exact&query_format=advanced&bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&longdesc=unboxed&email1=choller%40mozilla.com&component=JavaScript%20Engine&component=JavaScript%20Engine%3A%20JIT&component=JavaScript%3A%20GC&component=JavaScript%3A%20Internationalization%20API&component=JavaScript%3A%20Standard%20Library&longdesc_type=substring&product=Core

Comment 4

[Jan de Mooij [:jandem]]

Comment on attachment 8602263 [details] [diff] [review]
patch

Review of attachment 8602263 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/89c05305c708

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/0d05c148ef07 for apparently making hazard builds fail:
https://treeherder.mozilla.org/logviewer.html#?job_id=9810759&repo=mozilla-inbound
https://treeherder.mozilla.org/logviewer.html#?job_id=9811039&repo=mozilla-inbound

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c112db453761

Comment 8

[Carsten Book [:Tomcat]]

sorry had to back this out for test failures like https://treeherder.mozilla.org/logviewer.html#?job_id=9874995&repo=mozilla-inbound

Comment 9

[Pulsebot]

Backout:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c4609a600f02

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/356231081116

Comment 11

[Phil Ringnalda (:philor)]

Bouncy!

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/df00fd242b33 for (with retriggers) 2 of 10 Linux32 opt e10s browser-chrome runs crashing like https://treeherder.mozilla.org/logviewer.html#?job_id=9908263&repo=mozilla-inbound

Comment 12

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/322487136b28

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/322487136b28

Comment 14

[Hannes Verschore [:h4writer]]

The regression detection was quite pleased with this landing.
Overall this is an improvement on octane/kraken/ss.
There are some specific tests that regressed and might be interesting to look at,
but given the overall improvement, I'm not tracking the specific tests.

Mac OS X 10.10 32-bit (Mac Pro, shell)
- misc: typedobj-simple-struct-typedobj: 31.37% (regression)
- misc: typedobj-splay-typedobj: 2.66% (regression)
- misc: bugs-1131099-lodash2: 7.35% (regression)
- misc: basic-hoist-bounds-check: 2.84% (regression)
- octane: Box2D: -1.94% (regression)
- octane: Typescript: -4.39% (regression)
- dart: Richards: 17.91% (regression)

More details: http://arewefastyet.com/regressions/#/regression/1578297

Mac OS X 10.10 64-bit (Mac Pro, shell)
- kraken: stringify-tinderbox: 9.38% (regression)
- kraken: crypto-aes: 1.58% (regression)
- misc: bugs-847389-jpeg2000: 0.58% (regression)
- dart: Richards: 7.01% (regression)

More details: http://arewefastyet.com/regressions/#/regression/1578649